feat: improve dropped point logging#26257
Merged
davidby-influx merged 5 commits intomaster-1.xfrom Apr 18, 2025
Merged
Conversation
gwossum
reviewed
Apr 16, 2025
coordinator/points_writer.go
Outdated
| if s.Dropped() <= 0 { | ||
| return "" | ||
| } | ||
| return fmt.Sprintf("dropped %d points outside retention policy and %d points outside write window: %s to %s", |
Member
There was a problem hiding this comment.
Do we want to include the retention policy and/or write window bounds in the summary? Might make debugging customer issues easier, especially if their retention or write window is now what they think it is.
Contributor
Author
There was a problem hiding this comment.
DroppedPoint.String() prints that information, so we get it for the max and min points.
Log the reason for a point being dropped, the type of boundary violated, and the time that was the boundary. Prints the maximum and minimum points (by time) that were dropped closes #26252
a885a1f to
e10e9ca
Compare
gwossum
reviewed
Apr 18, 2025
| atomic.AddInt64(&w.stats.SubWriteOK, 1) | ||
|
|
||
| if err == nil && len(shardMappings.Dropped) > 0 { | ||
| err = tsdb.PartialWriteError{Reason: "points beyond retention policy or outside permissible write window", |
Member
There was a problem hiding this comment.
The new code would have an error message of "dropped %d points outside retention policy of duration". I assume this message is what the client will receive. Any risk of this breaking any client libraries or C1 alerting?
Contributor
Author
There was a problem hiding this comment.
In theory, it could break picky client code, but my hope is that people are switching on the 4XX HTTP error, not the message text.
davidby-influx
added a commit
that referenced
this pull request
Apr 22, 2025
Log the reason for a point being dropped, the type of boundary violated, and the time that was the boundary. Prints the maximum and minimum points (by time) that were dropped closes #26252 * fix: better time formatting and additional testing * fix: differentiate point time boundary violations * chore: clean up switch statement * fix: improve error messages (cherry picked from commit 62e803e) closes #26295
devanbenz
pushed a commit
that referenced
this pull request
Sep 24, 2025
Log the reason for a point being dropped, the type of boundary violated, and the time that was the boundary. Prints the maximum and minimum points (by time) that were dropped closes #26252 * fix: better time formatting and additional testing * fix: differentiate point time boundary violations * chore: clean up switch statement * fix: improve error messages (cherry picked from commit 62e803e)
devanbenz
added a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log the reason for a point being dropped,
the type of boundary violated, and the
time that was the boundary. Prints the
maximum and minimum points (by time)
that were dropped
closes #26252