Merged
Conversation
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
Do we need the ./... which has gone away?
devanbenz
added a commit
that referenced
this pull request
May 9, 2025
* feat: Use ldext in build-test.sh * feat: use env vars * feat: re-add ./... to go-test-compile * chore: update cross-builder tag * chore: change cross builder tag to deb10f07f31767ee55b0b5f87edd34635673cf41 * chore: use latest instead of tag * feat: run ci * feat: typo in build-tests.sh (cherry picked from commit cb5072c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the build_windows function in build-tests.sh to use the -ldext flag to specify that we are using the windows compiler for cross compilation. It also removes -x as a flag which would output all file names as it was built. This fixes the build-tests script.