fix: switch MeasurementFields from atomic.Value to sync.Map#26022
Merged
davidby-influx merged 1 commit intomaster-1.xfrom Feb 14, 2025
Merged
fix: switch MeasurementFields from atomic.Value to sync.Map#26022davidby-influx merged 1 commit intomaster-1.xfrom
davidby-influx merged 1 commit intomaster-1.xfrom
Conversation
stuartcarnie
approved these changes
Feb 14, 2025
Contributor
stuartcarnie
left a comment
There was a problem hiding this comment.
Very nice – code becomes a lot cleaner 🥳
davidby-influx
added a commit
that referenced
this pull request
Feb 14, 2025
davidby-influx
added a commit
that referenced
this pull request
Feb 14, 2025
* fix: lock MeasurementFields while validating (#25998) There was a window where a race between writes with differing types for the same field were being validated. Lock the MeasurementFields struct during field validation to avoid this. closes #23756 (cherry picked from commit 5a20a83) helps #26001 * fix: switch MeasurementFields from atomic.Value to sync.Map (#26022) Simplify and speed up synchronization for MeasurementFields structures by switching from a mutex and atomic.Value to a sync.Map (cherry picked from commit b617eb2) closes #26001
2 tasks
devanbenz
pushed a commit
that referenced
this pull request
May 9, 2025
* fix: lock MeasurementFields while validating (#25998) There was a window where a race between writes with differing types for the same field were being validated. Lock the MeasurementFields struct during field validation to avoid this. closes #23756 (cherry picked from commit 5a20a83) helps #26001 * fix: switch MeasurementFields from atomic.Value to sync.Map (#26022) Simplify and speed up synchronization for MeasurementFields structures by switching from a mutex and atomic.Value to a sync.Map (cherry picked from commit b617eb2) closes #26001 (cherry picked from commit 8711e2d)
devanbenz
pushed a commit
that referenced
this pull request
May 9, 2025
* fix: lock MeasurementFields while validating (#25998) There was a window where a race between writes with differing types for the same field were being validated. Lock the MeasurementFields struct during field validation to avoid this. closes #23756 (cherry picked from commit 5a20a83) helps #26001 * fix: switch MeasurementFields from atomic.Value to sync.Map (#26022) Simplify and speed up synchronization for MeasurementFields structures by switching from a mutex and atomic.Value to a sync.Map (cherry picked from commit b617eb2) closes #26001 (cherry picked from commit 8711e2d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and speed up synchronization for
MeasurementFields structures by switching
from a mutex and atomic.Value to a sync.Map