Skip to content

fix: defer calls that return a closure need to be called#25951

Merged
philjb merged 3 commits intomain-2.xfrom
pjb/25950/fix-defer-with-capture
Feb 4, 2025
Merged

fix: defer calls that return a closure need to be called#25951
philjb merged 3 commits intomain-2.xfrom
pjb/25950/fix-defer-with-capture

Conversation

@philjb
Copy link
Copy Markdown
Contributor

@philjb philjb commented Jan 31, 2025 •
edited
Loading

This fix will stop leaking file handles to temporary files.

Describe your proposed changes here.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

@philjb philjb requested a review from davidby-influx January 31, 2025 23:15
davidby-influx
davidby-influx approved these changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidby-influx
davidby-influx approved these changes Feb 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philjb philjb merged commit de12b6d into main-2.x Feb 4, 2025
1 check passed
@philjb philjb mentioned this pull request Feb 4, 2025
Closed
@davidby-influx davidby-influx linked an issue May 8, 2025 that may be closed by this pull request
[OSS 2.x] Sqlite doesn't close temporary backup file handle after use #25950
Closed
@davidby-influx davidby-influx mentioned this pull request May 9, 2025
Closed
devanbenz pushed a commit that referenced this pull request May 9, 2025
@philjb @devanbenz
fix: defer calls that return a closure need to be called (#25951)
364830c 
* fix: defer calls that return a closure need to be called

* fixes #25950

* chore: avoid a double close

* chore: call defer

(cherry picked from commit de12b6d)
devanbenz pushed a commit that referenced this pull request May 9, 2025
@philjb @devanbenz
fix: defer calls that return a closure need to be called (#25951)
2f89a66 
* fix: defer calls that return a closure need to be called

* fixes #25950

* chore: avoid a double close

* chore: call defer

(cherry picked from commit de12b6d)
devanbenz added a commit that referenced this pull request May 12, 2025
@devanbenz @philjb
fix: defer calls that return a closure need to be called (#25951) (#2…
9dc4b98 
…6393)

Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com>
fixes #25950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidby-influx davidby-influx davidby-influx approved these changes

@stuartcarnie stuartcarnie Awaiting requested review from stuartcarnie

Assignees

@philjb philjb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OSS 2.x] Sqlite doesn't close temporary backup file handle after use

2 participants

@philjb @davidby-influx