feat: add option to flush WAL on shutdown#25444
Merged
Conversation
Add `--storage-wal-flush-on-shutdown` to flush WAL on database shutdown. On successful shutdown, all WAL data will be committed to TSM files and the WAL directories will not contain any .wal files. Closes: #25422
Remove FlushWAL from tsdb.Engine interface make it a private method on tsm1.Engine. Add comment explaining why the directory layout for Store objects in tests was changed.
davidby-influx
approved these changes
Oct 10, 2024
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
LGTM: this is really nice code.
| t.Errorf("unexpected tsm-madv-willneed:\n\nexp=%v\n\ngot=%v\n\n", exp, got) | ||
| } | ||
| `, &c) | ||
| require.NoError(t, err) |
Contributor
There was a problem hiding this comment.
Nice simplification
| walCloseErr = e.WAL.Close() | ||
| } | ||
| return err | ||
| return errors.Join(flushErr, setCloseErr, storeCloseErr, walCloseErr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--storage-wal-flush-on-shutdownto flush WAL on database shutdown. On successful shutdown, all WAL data will be committed to TSM files and the WAL directories will not contain any .wal files.Closes: #25422