fix: update broken flux and perf tests (main-2.x)#24617
Merged
Conversation
davidby-influx
requested changes
Jan 31, 2024
Contributor
davidby-influx
left a comment
There was a problem hiding this comment.
Some merging with a recent PR may be necessary
| install_go() { | ||
| # install golang latest version | ||
| go_endpoint="go1.17.3.linux-amd64.tar.gz" | ||
| go_endpoint="go1.17.11.linux-amd64.tar.gz" |
Contributor
There was a problem hiding this comment.
Why isn't this the Go version we compile with (currently 1.20.XX)?
query/stdlib/universe/last_test.flux
Outdated
| result = csv.from(csv: input) | ||
| |> testing.load() | ||
| |> range(start: -3y) | ||
| |> range(start: -10y) |
Contributor
Some perf tests had to be temporarily disabled. Work is needed in the pref_tests repositories to make them work again.
9a6aa9b to
353c28c
Compare
bnpfeife
added a commit
that referenced
this pull request
Jan 31, 2024
* chore: download repository key to file * fix: broken perf tests Some perf tests had to be temporarily disabled. Work is needed in the pref_tests repositories to make them work again.
bnpfeife
added a commit
that referenced
this pull request
Jan 31, 2024
* chore: download repository key to file * fix: broken perf tests Some perf tests had to be temporarily disabled. Work is needed in the pref_tests repositories to make them work again.
bnpfeife
added a commit
that referenced
this pull request
Jan 31, 2024
* fix: update broken flux and perf tests (main-2.x) (#24617) * chore: download repository key to file * fix: broken perf tests Some perf tests had to be temporarily disabled. Work is needed in the pref_tests repositories to make them work again. * fix(tsi1/partition/test): fix data race in test code (#24613) * fix(tsi1/partition/test): fix data race in test code TestPartition_Compact_Write_Fail test was not locking the partition before changing the value of MaxLogFileSize. This PR exports the mutex of the partition to allow the test to access it and lock. Alternatives require more changes such as a Setter method if we need to hide the mutex. * fixes #24042, for #24040 * chore: complete renaming of mutex in file and fix flux test The flux test is another failing test because it was using a relative time range. --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com>
bnpfeife
added a commit
that referenced
this pull request
Jan 31, 2024
* fix: update broken flux and perf tests (main-2.x) (#24617) * chore: download repository key to file * fix: broken perf tests Some perf tests had to be temporarily disabled. Work is needed in the pref_tests repositories to make them work again. * fix(tsi1/partition/test): fix data race in test code (#24613) * fix(tsi1/partition/test): fix data race in test code TestPartition_Compact_Write_Fail test was not locking the partition before changing the value of MaxLogFileSize. This PR exports the mutex of the partition to allow the test to access it and lock. Alternatives require more changes such as a Setter method if we need to hide the mutex. * fixes #24042, for #24040 * chore: complete renaming of mutex in file and fix flux test The flux test is another failing test because it was using a relative time range. --------- Co-authored-by: Phil Bracikowski <13472206+philjb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make CI work properly again.