Skip to content

feat: add selection toolbar window for mac#980

Merged
SteveLauC merged 43 commits intomainfrom
s-1105
Nov 27, 2025
Merged

feat: add selection toolbar window for mac#980
SteveLauC merged 43 commits intomainfrom
s-1105

Conversation

@RainyNight9
Copy link
Copy Markdown
Contributor

@RainyNight9 RainyNight9 commented Nov 17, 2025

What does this PR do

image image image

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@RainyNight9 RainyNight9 marked this pull request as draft November 17, 2025 08:34
@RainyNight9 RainyNight9 changed the title S 1105 feat: add selection toolbar window Nov 17, 2025
@RainyNight9 RainyNight9 marked this pull request as ready for review November 20, 2025 13:29
@RainyNight9 RainyNight9 changed the title feat: add selection toolbar window add selection toolbar window for mac Nov 20, 2025
@RainyNight9 RainyNight9 marked this pull request as draft November 20, 2025 13:57
RainyNight9 and others added 5 commits November 24, 2025 09:15
To make coco-app compile in CI:

```
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hashbrown-0.15.5/src/raw/mod.rs:3856:12
     |
3856 | impl<T, A: Allocator> RawIntoIter<T, A> {
     |            ^^^^^^^^^
     |
     = note: see issue #32838 <rust-lang/rust#32838> for more information
     = help: add `#![feature(allocator_api)]` to the crate attributes to enable
     = note: this compiler was built on 2025-06-25; consider upgrading it if it is out of date
```

I don't know why it does not compile, feature `allocator-api2` is
enabled for `hashbrown 0.15.5`, so technically [1] it should not use the
allocator APIs from the std. According to [2], enabling the `nightly`
feature of `allocator-api2` may cause this issue as well, but it is not
enabled in our case either.

Anyway, enabling `#![feature(allocator_api)]` should make it work.

[1]: https://github.com/rust-lang/hashbrown/blob/b751eef8e99ccf3652046ef4a9e1ec47c1bfb78d/src/raw/alloc.rs#L26-L47
[2]: rust-lang/hashbrown#564
SteveLauC added a commit to infinilabs/get-selected-text that referenced this pull request Nov 24, 2025
Without this, [1] would have both hashbrown 0.14.x and 0.15.x in the
dependency list, which leads to this error:

```
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hashbrown-0.15.5/src/raw/mod.rs:3856:12
     |
3856 | impl<T, A: Allocator> RawIntoIter<T, A> {
     |            ^^^^^^^^^
     |
     = note: see issue #32838 <rust-lang/rust#32838> for more information
     = help: add `#![feature(allocator_api)]` to the crate attributes to enable
     = note: this compiler was built on 2025-06-25; consider upgrading it if it is out of date
```

I am not clear about the root cause as in my understanding [2], it
should not happen. I tried several workarounds, none of them worked. So I
have to remove `hashbrown 0.15.x` from dependencies by bumping `lru`.

[1]: infinilabs/coco-app#980
[2]: infinilabs/coco-app@a5506e1
@RainyNight9 RainyNight9 marked this pull request as ready for review November 25, 2025 01:01
@RainyNight9 RainyNight9 changed the title add selection toolbar window for mac feat: add selection toolbar window for mac Nov 27, 2025
@SteveLauC SteveLauC merged commit ff7721d into main Nov 27, 2025
7 checks passed
@SteveLauC SteveLauC deleted the s-1105 branch November 27, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants