🎉 This PR is included in version 1.12.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@claude Please analyse the changes and tell me if as a consumer of this library can I configure the status codes that are retryable ?

Also I would like to know if there is a callback that I can use to log out the retries in the consumer application for better visibility.

Claude finished @edenreich's task —— View job

Analysis of Retry Implementation

I've analyzed the retry implementation changes in this PR. Here are the answers to your questions:

❌ Status Code Configurability

No, you cannot configure which status codes are retryable as a consumer of this library. The retryable status codes are hardcoded in the isRetryableStatusCode function in sdk.go:73-87:

func isRetryableStatusCode(statusCode int) bool {
    switch statusCode {
    case
        http.StatusRequestTimeout,      // 408
        http.StatusTooManyRequests,     // 429
        http.StatusInternalServerError, // 500
        http.StatusBadGateway,          // 502
        http.StatusServiceUnavailable,  // 503
        http.StatusGatewayTimeout:      // 504
        return true
    default:
        return false
    }
}

These status codes are fixed and cannot be modified through the RetryConfig.

❌ Retry Logging/Callback Mechanism

No, there is no callback or logging mechanism available for consumers to monitor retry attempts. The current implementation:

• Executes retries silently in the executeWithRetry function (sdk.go:169-208)
• Does not expose any hooks, callbacks, or events for retry attempts
• Provides no visibility into retry behavior for debugging or monitoring

🔧 Current RetryConfig Options

The RetryConfig struct in types.go:67-79 only allows configuring:

type RetryConfig struct {
    Enabled           bool  // Enable/disable retry logic
    MaxAttempts       int   // Max retry attempts (including initial)
    InitialBackoffSec int   // Initial backoff delay in seconds
    MaxBackoffSec     int   // Maximum backoff delay in seconds
    BackoffMultiplier int   // Multiplier for exponential backoff
}

💡 Suggestions for Enhancement

To address your needs, the retry implementation could be enhanced with:

1. Configurable Status Codes:

   type RetryConfig struct {
       // ... existing fields
       RetryableStatusCodes []int // Custom list of retryable status codes
   }

2. Retry Callback/Observer:

   type RetryCallback func(attempt int, err error, delay time.Duration)
   
   type RetryConfig struct {
       // ... existing fields  
       OnRetry RetryCallback // Called before each retry attempt
   }

These enhancements would provide the configurability and observability you're looking for without breaking existing functionality.

Todo List:

• Read types.go to understand RetryConfig structure
• Read sdk.go to analyze retry implementation
• Check for status code configurability
• Look for callback/logging mechanisms
• Provide detailed analysis

@claude Sounds like a plan, let's implement these.

Claude finished @edenreich's task —— View job

Implementation Complete! 🎉

I've successfully implemented both requested enhancements to the retry logic:

Todo List

• Read repository guidelines (CLAUDE.md)
• Analyze current retry implementation
• Design enhancements with backward compatibility
• Implement configurable status codes
• Implement retry callback mechanism
• Update tests for new functionality
• Run tests and lint
• Commit changes

✅ Configurable Status Codes

Added RetryableStatusCodes []int field to RetryConfig:

• When nil/empty → uses default codes (408, 429, 500, 502, 503, 504)
• When provided → only retries on your custom status codes

✅ Retry Callback Mechanism

Added OnRetry func(attempt int, err error, delay time.Duration) field:

• Called before each retry attempt
• attempt: Retry number (1, 2, 3...)
• err: The error that triggered the retry
• delay: Backoff duration until next attempt

Usage Examples

Configure custom retryable status codes:

retryConfig := &RetryConfig{
    Enabled: true,
    MaxAttempts: 3,
    RetryableStatusCodes: []int{418, 422, 503}, // Only retry these
}

Add retry logging/monitoring:

retryConfig := &RetryConfig{
    Enabled: true,
    MaxAttempts: 3,
    OnRetry: func(attempt int, err error, delay time.Duration) {
        log.Printf("Retry attempt %d: %v (waiting %v)", attempt, err, delay)
    },
}

Combine both features:

retryConfig := &RetryConfig{
    Enabled:              true,
    MaxAttempts:          3,
    RetryableStatusCodes: []int{418, 503, 504},
    OnRetry: func(attempt int, err error, delay time.Duration) {
        metrics.IncrementRetryCounter()
        log.Printf("Retrying request (attempt %d): %v", attempt, err)
    },
}

✅ Backward Compatibility

• Existing code works unchanged
• Default behavior preserved when new fields are nil/empty
• All existing tests continue to pass

✅ Comprehensive Testing

Added 4 new test functions with 15+ test cases covering:

• Custom status code configurations
• Retry callbacks with parameter validation
• Combined features functionality
• Nil callback handling
• Backward compatibility scenarios

Results: All tests pass (21.045s) ✅ | Linter: 0 issues ✅

Changes Committed

• types.go: Enhanced RetryConfig struct
• sdk.go: Updated retry logic to use new fields
• sdk_test.go: Added comprehensive test coverage

Commit: 1d3cefa - feat(retry): Add configurable status codes and callback mechanism

🎉 This PR is included in version 1.12.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

🎉 This PR is included in version 1.12.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀