Conversation
…d DefaultA2AProtocolHandler - Remove unused `backgroundTaskHandler` field from `DefaultA2AProtocolHandler` - Eliminate `streamingTaskHandler` duplication using method parameter injection - Update A2AProtocolHandler interface to accept StreamableTaskHandler as parameter - Ensure single source of truth for task handlers (server only) - Fix synchronization issues with `SetStreamingTaskHandler()` - Update tests and regenerate mocks to match new interface - All linting checks pass and tests continue to work Resolves issues identified in task handler management: - Dead code removal - Architectural cleanup - Improved dependency injection - Better testability Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
ig-semantic-release-bot bot
added a commit
that referenced
this pull request
Oct 11, 2025
## [0.14.0](v0.13.1...v0.14.0) (2025-10-11) ### ✨ Features * Add the callbacks ready to be used by the agent ([#94](#94)) ([84632f3](84632f3)) * **types:** Refactor Part deserialization to use concrete types ([#104](#104)) ([22d192e](22d192e)), closes [#102](#102) ### ♻️ Improvements * Consolidate the logic of the agent and remove redundancy ([#93](#93)) ([54e5e71](54e5e71)) * **docker-compose:** Remove port mappings for server service to avoid confusion ([3df7b08](3df7b08)) * **server:** Remove handler duplication between A2AServerImpl and DefaultA2AProtocolHandler ([#101](#101)) ([75b9c20](75b9c20)) ### 🐛 Bug Fixes * Improve validation logic for task handler configuration ([#98](#98)) ([34d6354](34d6354)) ### 👷 CI * Add Prettier setup and formatting steps for Go and markdown files ([#105](#105)) ([f2a1994](f2a1994)) ### 📚 Documentation * **examples:** Add input-required flow examples ([#96](#96)) ([17764f3](17764f3)) ### 🔧 Miscellaneous * **deps:** Update claude-code to 2.0.8 and install gh cli version 2.81.0 in flox environment ([4d6e41a](4d6e41a))
Contributor
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Problem
There was unnecessary duplication and dead code in task handler management between
A2AServerImplandDefaultA2AProtocolHandler, creating maintenance burden and synchronization issues.Solution
Implemented the recommended method parameter injection approach:
backgroundTaskHandlerfield fromDefaultA2AProtocolHandlerstreamingTaskHandlerduplication using method parameter injectionSetStreamingTaskHandler()Benefits
Testing
task lint)task test)Generated with Claude Code