Skip to content

Use stable thecodingmachine/safe#885

Merged
theofidry merged 3 commits intoinfection:masterfrom
snapshotpl:patch-1
Dec 19, 2019
Merged

Use stable thecodingmachine/safe#885
theofidry merged 3 commits intoinfection:masterfrom
snapshotpl:patch-1

Conversation

@snapshotpl
Copy link
Copy Markdown
Contributor

No description provided.

@theofidry
Copy link
Copy Markdown
Member

why not pushing for the beta only instead of allowing ^0.1 as well?

@sidz
Copy link
Copy Markdown
Member

sidz commented Dec 11, 2019

do we really would like to use library in the beta/alpha version stage? @theofidry @maks-rafalko

@maks-rafalko
Copy link
Copy Markdown
Member

do we really would like to use library in the beta/alpha version stage?

Well, although we are safe since we are using composer.lock file, I would still avoid using beta versions as a direct dependencies in Infection.

As I understand, @snapshotpl wants to be able to install Infection to his project, where 1.0.0.@beta is already used.

What if I suggest you using Infection PHAR distribution instead and forget about conflicted dependencies ;) ?

@snapshotpl
Copy link
Copy Markdown
Contributor Author

@maks-rafalko that's great idea, however it's not simple to install and maintain infection's phar like phpstan or rector

@sidz
Copy link
Copy Markdown
Member

sidz commented Dec 11, 2019 via email

@snapshotpl
Copy link
Copy Markdown
Contributor Author

I can download phpstan as phar via composer

@theofidry
Copy link
Copy Markdown
Member

I would still avoid using beta versions as a direct dependencies in Infection.

In this specific case we use the dev version (0.1) which is not any safer than a beta

@maks-rafalko
Copy link
Copy Markdown
Member

What is the benefit to use PHAR through composer rather than just download it or use https://phar.io/ to manage PHARs?

@snapshotpl
Copy link
Copy Markdown
Contributor Author

I don't need to change nothing in my project. Like phpstan did in 0.12. After composer install I just get phar. In your case in need to change my local and production deployment process.

Copy link
Copy Markdown
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer won't install beta versions by default IIRC, so I don't see what harm there can be here.

On the other hand, this can't be merged without composer.lock being updated. I don't see this change here. I didn't look in Travis failures yet, but I that the reason probably.

@theofidry
Copy link
Copy Markdown
Member

theofidry commented Dec 18, 2019

@snapshotpl any chance to update the PR? Would love to get this one merged :)

@snapshotpl snapshotpl changed the title Allow thecodingmachine/safe with 1.0 beta Use stable thecodingmachine/safe Dec 19, 2019
@snapshotpl
Copy link
Copy Markdown
Contributor Author

@theofidry thecodingmachine/safe is now in stable version :)

@theofidry theofidry merged commit d61bb6f into infection:master Dec 19, 2019
@theofidry
Copy link
Copy Markdown
Member

Thank you @snapshotpl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants