Use stable thecodingmachine/safe#885
Conversation
|
why not pushing for the beta only instead of allowing |
|
do we really would like to use library in the beta/alpha version stage? @theofidry @maks-rafalko |
Well, although we are safe since we are using As I understand, @snapshotpl wants to be able to install Infection to his project, where What if I suggest you using Infection PHAR distribution instead and forget about conflicted dependencies ;) ? |
|
@maks-rafalko that's great idea, however it's not simple to install and maintain infection's phar like phpstan or rector |
|
What is difference between phar for phpstan and infection?
ср, 11 дек. 2019 г., 10:26 Witold Wasiczko <notifications@github.com>:
… @maks-rafalko <https://github.com/maks-rafalko> that's great idea,
however it's not simple to install and maintain infection's phar like
phpstan <https://github.com/phpstan/phpstan> or rector
<https://github.com/rectorphp/rector-prefixed>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#885?email_source=notifications&email_token=AAJ55VSSUF2F4LSQ72LMY5LQYCIZPA5CNFSM4JZFIMV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGSESII#issuecomment-564414753>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ55VRF7PLPOGENZSGADC3QYCIZPANCNFSM4JZFIMVQ>
.
|
|
I can download phpstan as phar via composer |
In this specific case we use the dev version (0.1) which is not any safer than a beta |
|
What is the benefit to use PHAR through composer rather than just download it or use https://phar.io/ to manage PHARs? |
|
I don't need to change nothing in my project. Like phpstan did in 0.12. After composer install I just get phar. In your case in need to change my local and production deployment process. |
There was a problem hiding this comment.
Composer won't install beta versions by default IIRC, so I don't see what harm there can be here.
On the other hand, this can't be merged without composer.lock being updated. I don't see this change here. I didn't look in Travis failures yet, but I that the reason probably.
|
@snapshotpl any chance to update the PR? Would love to get this one merged :) |
|
@theofidry |
|
Thank you @snapshotpl |
No description provided.