change to use poll field instead of active field #690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to make more sense to use the (new?) poll field rather than active field in case there are switches active but we don't want IXPM to poll them.
|
@barryo Any chance we can get this merged please? :) |
Member
|
Hey @ichilton I can't merge this immediately I'm afraid 😢 I need a chance to look at the original semantics of Then docs + release notes may all need to be updated. If you're happy with your updates, can you just use a locally modified version for now? |
|
@barryo Roger that! - thanks! We are using a locally modified version for now.... just would prefer to be stock :) |
barryo
added a commit
that referenced
this pull request
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to make more sense to use the (new?) poll field rather than active field in case there are switches active but we don't want IXPM to poll them.