fix: Add missing entitlements xml in embedded signature size calculation#40
Closed
marysaka wants to merge 1 commit into
Closed
fix: Add missing entitlements xml in embedded signature size calculation#40marysaka wants to merge 1 commit into
marysaka wants to merge 1 commit into
Conversation
roblabla
approved these changes
Nov 6, 2022
roblabla
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the MR!
Contributor
Author
|
Seems like the runner died, could it be possible to restart it? |
indygreg
approved these changes
Nov 8, 2022
indygreg
left a comment
Owner
There was a problem hiding this comment.
Looks good. I'm going to amend this commit during merge to include an entry in the changelog.
Thank you for sending a fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #32