Improve performance of toArrayLike#222
Merged
fanatid merged 6 commits intoindutny:masterfrom Aug 9, 2019
Merged
Conversation
chjj
added a commit
to bcoin-org/bcrypto
that referenced
this pull request
Aug 1, 2019
fbba685 to
791750a
Compare
Merged
ivanshukhov
pushed a commit
to Kapoio/bn.js
that referenced
this pull request
Jul 31, 2020
* add toArray to benchmark * optimize BN#toArrayLike * split BN#toArrayLike * fix bounds in toArrayLike* * add more tests for toArrayLike * save 1 op in toArrayLike* (cherry picked from commit b28644b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From 6x to 174x improvement. Was need turn off bignum, because node 12 not supported.