Merged
Conversation
Owner
|
Hey @zxlzy - following my comment here (#176 (comment)) would you like to adjust the function like in diskonaut: https://github.com/imsnif/diskonaut/blob/main/src/ui/format/truncate.rs#L17-L37 ? |
Contributor
Author
|
@imsnif You are right. I have copy some code from diskonaut and make sure it passed all existing test cases. Because of I am a greenhand of rust programming. I can't add test cases for split Chinese for now. |
Owner
|
Hey @zxlzy, thanks for this! I don't think it's critical to add test cases for this. It looks good to me. I'll fix the CI issues on main. |
imsnif
added a commit
that referenced
this pull request
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix that #176