Conversation
kkysen
commented
Aug 21, 2025
Contributor
Author
kkysen
left a comment
There was a problem hiding this comment.
@fw-immunant, I think you previously said this looked good, so if you could review quickly and we can merge it, that'd be great. I don't want #1306 to get too large, so I'd like to merge the simpler parts of it first.
…sion_test}` into `IndexMap`s instead of `HashMap`s Previously, `macro_invocations` was a `HashMap`, and thus iterating through it was unordered, which populated the `Vec<CExprId>` of `macro_expansions` non-deterministically, which then resulted in non-deterministic output from `--translate-const-macros conservative`. I also changed the other `macro_*` maps to `IndexMap`, as many other maps in `TypedAstContext` are already `IndexMap`s, too, and it's likely that we want these stably ordered and deterministic.
b9834b2 to
3eec9fa
Compare
fw-immunant
approved these changes
Aug 21, 2025
Contributor
fw-immunant
left a comment
There was a problem hiding this comment.
It seems like the target branch should be master, but this change does seem reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--translate-const-macros conservativeto a lot moreCExprKinds #1306.Previously,
macro_invocationswas aHashMap, and thus iterating through it was unordered, which populated theVec<CExprId>ofmacro_expansionsnon-deterministically, which then resulted in non-deterministic output from--translate-const-macros conservative.I also changed the other
macro_*maps toIndexMap, as many other maps inTypedAstContextare alreadyIndexMaps, too, and it's likely that we want these stably ordered and deterministic.