Skip to content

Update Xtext to use ASM 9.9.0#1

Open
iloveeclipse wants to merge 1 commit into
mainfrom
issue_3525_2
Open

Update Xtext to use ASM 9.9.0#1
iloveeclipse wants to merge 1 commit into
mainfrom
issue_3525_2

Conversation

@iloveeclipse

@iloveeclipse iloveeclipse commented Oct 10, 2025

Copy link
Copy Markdown
Owner

Fixes eclipse-xtext#3525

Update all ASM references to 9.9.0

@github-actions

github-actions Bot commented Oct 10, 2025

Copy link
Copy Markdown

Test Results

  6 445 files    6 445 suites   3h 19m 38s ⏱️
 43 212 tests  42 629 ✅   581 💤 2 ❌
169 931 runs  167 598 ✅ 2 325 💤 8 ❌

For more details on these failures, see this check.

Results for commit 0ea83d8.

♻️ This comment has been updated with latest results.

@iloveeclipse

Copy link
Copy Markdown
Owner Author

org.eclipse.xtend.ide.tests has test
org.eclipse.xtend.ide.tests.autoedit.AutoEditTest

Failures: 
  AutoEditTest>AbstractCStyleLanguageAutoEditTest.testBug453205_01:624->AbstractAutoEditTest.assertState:69->AbstractAutoEditTest.assertState:74->Assert.assertEquals:146->Assert.assertEquals:117 expected:</*
[ * ]
* comment
*/> but was:</*
[]
* comment
*/>
  AutoEditTest>AbstractCStyleLanguageAutoEditTest.testBug453205_02:635->AbstractAutoEditTest.assertState:69->AbstractAutoEditTest.assertState:74->Assert.assertEquals:146->Assert.assertEquals:117 expected:</**********
[ * ]
 * "Fancy"
********...> but was:</**********
[]
 * "Fancy"
********...>

Tests run: 3120, Failures: 2, Errors: 0, Skipped: 53

@LorenzoBettini

Copy link
Copy Markdown

curiosity: Copilot with ChatGPT 4.1 or a more advanced model (e.g., Claude Sonnet)?

@iloveeclipse

Copy link
Copy Markdown
Owner Author

curiosity: Copilot with ChatGPT 4.1 or a more advanced model (e.g., Claude Sonnet)?

No idea, whatever is default. It wasn't able to properly change xtend file that is ASCII encoded and always saved it in UTF, which broke everything, even if I explicitly told to use given encoding. So I had to use Eclipse.

Note, Orbit doesn't have ASM 9.9.0 yet, so this PR has a hack in ‎xtext-latest.target: it uses platform repo to get ASM.
So probably it has to wait for Orbit, no idea how that all works with multiple target files.

But it seems that only two tests are failing:

  • AbstractCStyleLanguageAutoEditTest.testBug453205_01
  • AbstractCStyleLanguageAutoEditTest.testBug453205_02

Would be great if someone could look into.

@iloveeclipse

Copy link
Copy Markdown
Owner Author

Anyway, updated PR on main repo is eclipse-xtext#3528. That fails without ASM 9.9.0 being added to Orbit.

@trancexpress

Copy link
Copy Markdown

org.eclipse.xtend.ide.tests has test org.eclipse.xtend.ide.tests.autoedit.AutoEditTest

Failures: 
  AutoEditTest>AbstractCStyleLanguageAutoEditTest.testBug453205_01:624->AbstractAutoEditTest.assertState:69->AbstractAutoEditTest.assertState:74->Assert.assertEquals:146->Assert.assertEquals:117 expected:</*
[ * ]
* comment
*/> but was:</*
[]
* comment
*/>
  AutoEditTest>AbstractCStyleLanguageAutoEditTest.testBug453205_02:635->AbstractAutoEditTest.assertState:69->AbstractAutoEditTest.assertState:74->Assert.assertEquals:146->Assert.assertEquals:117 expected:</**********
[ * ]
 * "Fancy"
********...> but was:</**********
[]
 * "Fancy"
********...>

Tests run: 3120, Failures: 2, Errors: 0, Skipped: 53

I'll run the tests without this change, just in case its not related.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=453205

In the original bug report, the broken state looked like this:

/*
 *
 */
* comment
*/

While the actual state now looks like this:

/*
 * comment
 */

While expected is:

/*
 *
 * comment
 */

I.e. the star is not added anymore on pressing enter...

I've not ran Xtext tests from Eclipse, I'll have to check how to setup the Xtext workflow: https://github.com/eclipse-xtext/xtext/blob/main/CONTRIBUTING.md

Of course, if anyone familiar with the workflows can take a look, that would be great.

@trancexpress

Copy link
Copy Markdown

I see the same 2 fails on main branch. Just to be sure I deleted ~/.m2 (according to the mvn outputs, that is where its storing bundles when build/tests are running), deleted the repository and checked it out again. I ran the tests with:

export JAVA_HOME=/usr/lib/jvm/java-21/ && ./full-build.sh --tp=latest

@iloveeclipse should I open a ticket in the Advantest tracker to get the fixed, eventually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants