Update Xtext to use ASM 9.9.0#1
Conversation
Test Results 6 445 files 6 445 suites 3h 19m 38s ⏱️ For more details on these failures, see this check. Results for commit 0ea83d8. ♻️ This comment has been updated with latest results. |
5bea757 to
1176a84
Compare
|
org.eclipse.xtend.ide.tests has test |
|
curiosity: Copilot with ChatGPT 4.1 or a more advanced model (e.g., Claude Sonnet)? |
No idea, whatever is default. It wasn't able to properly change xtend file that is ASCII encoded and always saved it in UTF, which broke everything, even if I explicitly told to use given encoding. So I had to use Eclipse. Note, Orbit doesn't have ASM 9.9.0 yet, so this PR has a hack in But it seems that only two tests are failing:
Would be great if someone could look into. |
1176a84 to
0ea83d8
Compare
|
Anyway, updated PR on main repo is eclipse-xtext#3528. That fails without ASM 9.9.0 being added to Orbit. |
I'll run the tests without this change, just in case its not related. https://bugs.eclipse.org/bugs/show_bug.cgi?id=453205 In the original bug report, the broken state looked like this: While the actual state now looks like this: While expected is: I.e. the star is not added anymore on pressing enter... I've not ran Xtext tests from Eclipse, I'll have to check how to setup the Xtext workflow: https://github.com/eclipse-xtext/xtext/blob/main/CONTRIBUTING.md Of course, if anyone familiar with the workflows can take a look, that would be great. |
|
I see the same 2 fails on @iloveeclipse should I open a ticket in the Advantest tracker to get the fixed, eventually? |
Fixes eclipse-xtext#3525
Update all ASM references to 9.9.0