Update Xtext to use ASM 9.9.0#3528
Conversation
0ea83d8 to
3497cf4
Compare
|
Note, Orbit doesn't have ASM 9.9.0 yet, so this PR has a hack in |
|
Interestingly, this was not a problem on my own fork build, see iloveeclipse#1. |
|
See also jacoco/jacoco#1965 (comment) |
3497cf4 to
0c075c0
Compare
Test Results 6 445 files + 15 6 445 suites +15 3h 1m 7s ⏱️ - 22m 58s For more details on these failures, see this check. Results for commit 0c075c0. ± Comparison against base commit 1d41d02. This pull request removes 23 tests.♻️ This comment has been updated with latest results. |
|
FYI, the updates are available:
With these changes: |
|
the following files missed adjustments org.eclipse.xtext.xtext.wizard/xtend-gen/org/eclipse/xtext/xtext/wizard/TargetPlatformProject.java |
|
build also seems to have junit 5 problems [ERROR] maybe something pulls a wild mix of junit 5 and 6 |
|
i wont have any time to digg this week (any likely next) |
I guess "latest", but honestly I have no idea about Xtext targets. I believe they are per SDK release, so others shouldn't be affected by junit6 mix in latest. |
It's platform I-Build that has the mix, and tycho that pulls always latest if nothing is limited. See eclipse-platform/eclipse.platform.releng.aggregator#3399 and example fix in the platform: eclipse-platform/eclipse.platform#2192 |
|
theoretically all targets need to works practically
|
|
Yes, I understand that they all should work, otherwise they should be deleted. Getting one to work might be a good start though wouldn't it? |
|
replaced by eds pr |








Fixes #3525