[design] Revise training trigger and sampling caps (R2.3.5, R2.3.6)#14
Merged
Conversation
9014c20 to
8e0a806
Compare
ikolomi
approved these changes
Jun 1, 2026
ikolomi
left a comment
Owner
There was a problem hiding this comment.
Extend config descriptions with ZSTD information
e0d0b13 to
506bf46
Compare
Revise the training trigger and sampling model based on design discussion with @ikolomi: - Remove compression-dict-first-training-keys-count (replaced by min) - compression-dict-min-training-keys (default 1000): serves as BOTH the trigger to start a scan AND the minimum samples required to submit training. If scan doesn't reach the min, abort + 30s cooldown. - compression-dict-max-training-keys (default 10000): upper key cap - compression-training-buffer-size (default 16 MiB): upper buffer cap - Scan stops on whichever cap comes first, or keyspace exhausted - 30s hardcoded cooldown after failed attempt (avoids expensive repeated scans when not enough eligible keys exist) - Added both new knobs to the Advanced knobs config table (now 12)
506bf46 to
a86ebab
Compare
ikolomi
added a commit
that referenced
this pull request
Jun 2, 2026
Reconcile the planning docs with the implementation-phase changes
that landed after the original design walkthrough.
- idea-honing.md Q9: add a "Superseded during implementation"
annotation pointing to the new training-knob model from PR #14
(compression-dict-min-training-keys / -max-training-keys /
compression-training-buffer-size). The original walkthrough text
is preserved below the annotation for historical record.
- detailed-design.md §7.1 transparency-mode example: replace
--compression-dict-first-training-keys-count (removed in PR #14)
with --compression-dict-min-training-keys.
- detailed-design.md §2.12 heading: "Advanced knobs (12)" → "(11)".
Off-by-one count introduced when PR #14 reshuffled the table.
- summary.md: add a new "What changed during implementation"
section between the walkthrough section and the plan summary,
capturing the three substantive post-walkthrough refinements
(PR #14 training rewrite, PR #15 R2.5.6 read-hot gap, PR #13
QSBR plumbing).
Doc-only; no code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revises the training trigger and sampling model for S1.2 implementation, based on design discussion with @ikolomi.
Changes
Removed:
compression-dict-first-training-keys-count— replaced bycompression-dict-min-training-keysNew/updated knobs (all configurable):
compression-dict-min-training-keyscompression-dict-max-training-keyscompression-training-buffer-sizeCooldown:
Flow
Why
Design doc changes
compression-dict-min-training-keys, 30s cooldown on failureNo code changes — design doc only.