Merged
Conversation
Member
|
Is this sufficiently tested? (Or not yet?) |
holta
reviewed
Jun 30, 2022
Co-authored-by: A Holt <holta@users.noreply.github.com>
Contributor
Author
|
The networking part was squared away, didn't feel like building a new vm to test the vnstat role, something I don't normally install on my test box that is intended for more for the long term. |
Contributor
Author
|
Side note the workaround in netplan.yml is needed for the current linuxmint, noted a traceback in some of the feedback. |
Member
Does this have anything to do with the networkd-dispatcherd issue mentioned below? (Or completely unrelated?) |
Contributor
Author
|
You have the info you need, done with the hand holding. |
This was referenced Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug:
builds on #3272 to remove proxy debugging routine.
Description of changes proposed in this pull request:
Just drop the ping test while in install mode for vnstat, use iiab_stage in place of internet_available, whose is absent from network/defaults/main.yml or 0-init/defauts/main.yml