Skip to content

@m-anish plz help us come to a decision to get Nextcloud's php-* dependencies in place [non-php pkgs might also be added/removed?]#2258

Closed
holta wants to merge 6 commits intoiiab:masterfrom
holta:nextcloud-php-common
Closed

@m-anish plz help us come to a decision to get Nextcloud's php-* dependencies in place [non-php pkgs might also be added/removed?]#2258
holta wants to merge 6 commits intoiiab:masterfrom
holta:nextcloud-php-common

Conversation

@holta
Copy link
Copy Markdown
Member

@holta holta commented Feb 17, 2020

@holta holta added this to the 7.1 milestone Feb 17, 2020
@jvonau
Copy link
Copy Markdown
Contributor

jvonau commented Feb 17, 2020

no... php-mysql pulls in the correct dependencies for common
yes php-xml

@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 17, 2020

@jvonau I'm trying to understand:

@m-anish has included php-common as it might help the situation on some OS's ...but in the end are you saying php-common should definitely not be included in this list here?

@holta holta mentioned this pull request Feb 17, 2020
@jvonau
Copy link
Copy Markdown
Contributor

jvonau commented Feb 17, 2020

If you were to include php-common it might generate the same type of 'is a virtual package provided by:' error as the real package is php7.3-common that provides the virtual php-common package. As noted php-mysql correctly pulls in php7.3-mysql and php7.3-common which provides php-common. edit: Tried the apt install php-common test that looks like it would work right.

Any real reason you expanded the apt list from #2119 to include those other 8-9 problem virtual packages? Did you even try that list as provided or did you go straight to misunderstanding that some of those modules listed in prerequisites-for-manual-installation were modules at one point but that are now included in and provided by a different module, be it common, xml or some other package?

@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 17, 2020

Whatever our best-guesstimate as to what field communities likely (might) want for Nextcloud 19, 20, etc in the future should be fine for now. This is likely a moving target after all.

e.g. @m-anish was very forthcoming explaining that his list of Nextcloud prereq+associated packages ...which contains extras & at least 1 duplicate ...may work on Ubuntu 19.10 today, but not necessarily elsewhere!

I'm sure Anish can add some suggestions here when he gets back online in coming days?

Even if nothing is super-easy when Nextcloud install docs don't spell this out in a tangibly actionable way. To be clear, I'm not at all criticizing them for including bonus extras for implementers/communities who want that, e.g. for fast image previewing and interop with other apps etc! But I do wish Nextcloud's core requirements were spelled out in (more of) an unambiguous way.

e.g. Nextcloud's 1-line installer does something a bit different from their stated requirements ;)

@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 17, 2020

FWIW even though it doesn't align perfectly with Nextcloud's official instructions (!) their 1-line installer script here does offer insights:

check_command apt install -y \
    php"$PHPVER"-fpm \
    php"$PHPVER"-intl \
    php"$PHPVER"-ldap \
    php"$PHPVER"-imap \
    php"$PHPVER"-gd \
    php"$PHPVER"-pgsql \
    php"$PHPVER"-curl \
    php"$PHPVER"-xml \
    php"$PHPVER"-zip \
    php"$PHPVER"-mbstring \
    php"$PHPVER"-soap \
    php"$PHPVER"-smbclient \
    php"$PHPVER"-json \
    php"$PHPVER"-gmp \
    php"$PHPVER"-bz2 \
    php-pear
    # php"$PHPVER"-imagick \
    # libmagickcore-6.q16-3-extra

@holta holta added the question label Feb 18, 2020
@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 18, 2020

@m-anish when you review this, 2 main questions:

  • should we add php-common back in?
  • should many/most of the 9 php-* packages be removed from the list of things being installed on non-Raspbian OS's ?

@holta holta requested a review from m-anish February 18, 2020 13:16
@tim-moody
Copy link
Copy Markdown
Contributor

What problem is all this trying to solve? Did nextcloud magically stop working at some point and if so, what changed? Also, php modules needed by nextcloud should be in the nextcloud role unless used by other commonly installed roles.

@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 18, 2020

What problem is all this trying to solve?

2 things:

Also, php modules needed by nextcloud should be in the nextcloud role unless used by other commonly installed roles.

I (think!) everyone's in agreement there. Thanks @tim-moody for stating that upfront to make it clear.

@tim-moody tim-moody changed the title Install php-common to cover more of the bases, for Nextcloud Add php modules to support additional Nextcloud functionality Feb 18, 2020
@tim-moody
Copy link
Copy Markdown
Contributor

then then name php-uncommon would be more apt, but just php-modules would do.

@holta holta changed the title Add php modules to support additional Nextcloud functionality Refine which php & other packages should support Nextcloud: (1) based requirements + (2) media functionality etc Feb 18, 2020
@holta holta changed the title Refine which php & other packages should support Nextcloud: (1) based requirements + (2) media functionality etc Refine which php & other packages should support Nextcloud: (1) base requirements + (2) media functionality etc Feb 18, 2020
@tim-moody
Copy link
Copy Markdown
Contributor

How will you know when 'refine' is complete? Why do base requirements need changing as they worked before? The new title sounds like we are evaluating php modules and packages to see which should support nextcloud.

@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 18, 2020

I'm just hoping @m-anish can come up with a recommendation for all of us to take seriously, but I realize he's just getting back online (talked with him very quickly last night!) and so it may take him a few days until he has time for this.

@tim-moody tim-moody changed the title Refine which php & other packages should support Nextcloud: (1) base requirements + (2) media functionality etc Jerry & I have done our best, and almost any decision is needed to get Nextcloud's php-* dependencies in place here Feb 18, 2020
@holta holta changed the title Jerry & I have done our best, and almost any decision is needed to get Nextcloud's php-* dependencies in place here Jerry & I have done our best, and almost any decision is needed to get Nextcloud's php-* dependencies in place here [non-php pkgs might also be added/removed?] Feb 18, 2020
@jvonau
Copy link
Copy Markdown
Contributor

jvonau commented Feb 18, 2020

I'm not the originator of any of the Nextcloud PR's just a observer, commentator, debugger trying to pointing out weaknesses in the changes. I am not the hidden hand behind any of these changes, why is my name Mentioned?

@holta holta changed the title Jerry & I have done our best, and almost any decision is needed to get Nextcloud's php-* dependencies in place here [non-php pkgs might also be added/removed?] @m-anish plz help us come to a decision to get Nextcloud's php-* dependencies in place here [non-php pkgs might also be added/removed?] Feb 18, 2020
@holta
Copy link
Copy Markdown
Member Author

holta commented Feb 18, 2020

@jvonau's name removed from ticket subject line per his request.

(Thanks Jerry for helping inform these issues, even if @m-anish did all the initial work!)

@holta holta changed the title @m-anish plz help us come to a decision to get Nextcloud's php-* dependencies in place here [non-php pkgs might also be added/removed?] @m-anish plz help us come to a decision to get Nextcloud's php-* dependencies in place [non-php pkgs might also be added/removed?] Feb 18, 2020
@jvonau
Copy link
Copy Markdown
Contributor

jvonau commented Feb 22, 2020

another php install list from nextcloudpi

@holta
Copy link
Copy Markdown
Member Author

holta commented Mar 19, 2020

@m-anish let's close this and PR #2119 if you are no longer working on Nextloud, Ok?

(Now that PR #2294 is merged especially.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants