Initial stab at nextcloud playbook running on nginx by m-anish · Pull Request #2119 · iiab/iiab

m-anish · 2020-01-08T13:50:28Z

Not ready to be merged into master yet. I need help with:

Cleaning up the nginx conf for nextcloud. It currently 'works' but I need help in making sure everything is in order.
Enabling a file locking cache. You'll see commented out parts of the playbook trying to get a redis based file locking cache to work. I am facing issues so would like some help with that. Isn't strictly a blocker per se but would be good to have.
No raising of php or other limits so far implemented in this playbook.
No enabling of php opcache for this. Again, would offer performance benefits at the cost of extra ram I guess.
No memcache enabled.
No initial nextcloud setup takes places, but should be just a matter of migrating some ansible instructions from the older playbook.
I'd like a discussion on whether nginx conf should be a virtual server or like what it currently is.
use latest version of nextcloud instead of a hardcoded one

Tested on Ubuntu 19.10. Please test on more/other platforms. So far, the playbook should run to completion and you should get a working nextcloud setup at http://box.lan/nextcloud.

m-anish · 2020-01-08T13:54:45Z

+    #fastcgi_hide_header X-Powered-By;
+
+    # Path to the root of your installation
+    root /library/www/html/;


I had to do this instead of root /library/www/html/nextcloud/; because with that, the calls were going to .../nextcloud/nextcloud/...

m-anish · 2020-01-08T13:55:46Z

+    #add_header Referrer-Policy "no-referrer" always;
+    #add_header X-Content-Type-Options "nosniff" always;
+    #add_header X-Download-Options "noopen" always;
+    #add_header X-Frame-Options "SAMEORIGIN" always;
+    #add_header X-Permitted-Cross-Domain-Policies "none" always;
+    #add_header X-Robots-Tag "none" always;
+    #add_header X-XSS-Protection "1; mode=block" always;


The nextcloud admin console complains about a bunch of settings with the same name not enabled, but I don't know anything about this. Could this be the culprit? Is this relevant?

m-anish · 2020-01-08T13:56:39Z

@holta @jvonau @tim-moody @georgejhunt please test, review, help out if possible. :)

holta · 2020-01-08T14:07:44Z

Is this PR trying to address #2021 "Nextcloud stores its data in /opt/ instead of /library/" or not yet ?

holta · 2020-01-08T14:22:55Z

Does this PR address #2117 "NGINX: Nextcloud broken icons & broken links, erroneously contain http://127.0.0.1:8090" or not yet?

m-anish · 2020-01-08T14:23:15Z

Is this PR trying to address #2021 "Nextcloud stores its data in /opt/ instead of /library/" or not yet ?

not yet

m-anish · 2020-01-08T14:24:56Z

Does this PR address #2117 "NGINX: Nextcloud broken icons & broken links, erroneously contain http://127.0.0.1:8090" or not yet?

It seems so! I don't see broken links.

m-anish · 2020-01-08T14:29:56Z

+- name: Nextcloud - Uncomment lines from /etc/php/7.*/fpm/pool.d/www.conf
+  lineinfile:
+    dest: "/etc/php/{{ php_version }}/fpm/pool.d/www.conf"
+    regexp: "^;({{ item }}.*)$"
+    line: "\\1"
+    backrefs: yes
+    state: present
+  with_items:
+    - "env[HOSTNAME]"
+    - "env[PATH]"
+    - "env[TMP]"
+    - "env[TMPDIR]"
+    - "env[TEMP]"


This doesn't seem to work! Please fix.

holta · 2020-01-08T14:36:54Z

Please test on more/other platforms

Let's help everyone test frequently & on a diversity of OS's — by reminding them that Nextcloud downloads can be ~1000X faster if they follow these instructions that should be restored into nextcloud/defaults/main.yml :

# 2020-01-07: If installing IIAB often, download.nextcloud.com may throttle
# you to ~100 kbit/sec, delaying your IIAB install by an hour or more (#2112).
# The following line can avoid that: (but might install an older Nextcloud!)
# nextcloud_dl_url: http://d.iiab.io/packages
nextcloud_dl_url: https://download.nextcloud.com/server/releases

jvonau · 2020-01-08T16:53:52Z

How does updating nextcloud's nginx config file grow into a complete rewrite of the role? Don't forget to disable the nextcloud stanza in roles/nginx/tasks/uses_apache.yml

holta · 2020-01-08T16:55:15Z

Does this PR address #2117 "NGINX: Nextcloud broken icons & broken links, erroneously contain http://127.0.0.1:8090" or not yet?

It seems so! I don't see broken links.

Not-So-Good News: images/links remain broken when installing this PR (#2119) onto 182-rpi4-2GB-lite-PR2119-0108 = 10.8.0.42 (did you click exactly as #2117 describes, to see the broken images/icons/links when clicking on the Notifications dropdown in the top-right?)

Good News: this initial PR (#2119) basically works on Raspbian Lite on Raspberry Pi 4, as seen by http://10.8.0.42/nextcloud

CORRECTION: above test was using the wrong branch. Apologies. Restarting the test now...

jvonau · 2020-01-08T17:14:52Z

iiab-admin@box:~ $ cat /etc/nginx/conf.d/nextcloud-nginx.conf
location /nextcloud {
proxy_pass http://127.0.0.1:8090/nextcloud;
}

location ~ /nextcloud/.*.php$ {
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $remote_addr;
proxy_set_header Host $host;
proxy_pass http://127.0.0.1:8090;
}

using the old template from uses_apache.yml

m-anish · 2020-01-08T17:33:21Z

iiab-admin@box:~ $ cat /etc/nginx/conf.d/nextcloud-nginx.conf
location /nextcloud {
proxy_pass http://127.0.0.1:8090/nextcloud;
}

location ~ /nextcloud/.*.php$ {
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $remote_addr;
proxy_set_header Host $host;
proxy_pass http://127.0.0.1:8090;
}

using the old template from uses_apache.yml

How does updating nextcloud's nginx config file grow into a complete rewrite of the role? Don't forget to disable the nextcloud stanza in roles/nginx/tasks/uses_apache.yml

Thx for the pointer.

The older nextcloud playbook was long and twisted to accommodate different versions, settings, etc. on different OSes, which was relevant a while ago, but not anymore.

I just found it a lot cleaner to do from scratch, reducing the size of the playbook. Things are still left out as I point out, but it should just be a matter of copying some tasks over from the older playbook.

holta · 2020-01-08T18:08:02Z

I just found it a lot cleaner to do from scratch, reducing the size of the playbook.

Of course fine for a proof-of-concept to try out new things!

But after experimentation, it will be essential to add back the pieces that were very carefully refined over the years, including for example:

Implementers want the latest version of Nextcloud (latest.tar.bz2) just the same as they expect when installing WordPress, not a hard-coded version like nextcloud-17.0.2.tar.bz2
People who install/test IIAB frequently deserve downloads that are ~1000X faster, as is documented at https://github.com/iiab/iiab/blob/master/roles/nextcloud/defaults/main.yml#L21-L25 (Initial stab at nextcloud playbook running on nginx #2119 (comment)) so IIAB takes testing workflows seriously, which uphold our entire community.
IIAB requests 3 separate files in nextcloud/tasks :
1. install.yml
2. setup.yml [for DB, install wizards, etc]
3. enable.yml AKA enable-or-disable.yml
...i.e. what @jvonau just implemented across the most used IIAB playbooks, after extensive design discussions around Nov 2019.

And yes documentation needs to be readable too (OMG!) anyway thanks...just a quick summary of stuff needed as this PR #2119 hopefully stabilizes soon!

holta · 2020-01-08T19:12:34Z

-  file:
-    path: "{{ nextcloud_data_dir }}"
+#TODO: Figure out who should be owner of this directory    
+- name: Nextcloud - Extract source {{ doc_root }}/{{ nextcloud_url }}


Suggested change

- name: Nextcloud - Extract source {{ doc_root }}/{{ nextcloud_url }}

- name: Nextcloud - Extract source {{ doc_root }}{{ nextcloud_url }}

m-anish · 2020-01-08T19:38:16Z

I just found it a lot cleaner to do from scratch, reducing the size of the playbook.

Of course fine for a proof-of-concept to try out new things!

But after experimentation, it will be essential to add back the pieces that were very carefully refined over the years, including for example:
* Implementers want the latest version of Nextcloud ([latest.tar.bz2](https://download.nextcloud.com/server/releases/latest.tar.bz2)) just the same as they expect when installing WordPress, not a hard-coded version like nextcloud-17.0.2.tar.bz2

* People who install/test IIAB frequently deserve downloads that are ~1000X faster, as is documented at https://github.com/iiab/iiab/blob/master/roles/nextcloud/defaults/main.yml#L21-L25 ([#2119 (comment)](https://github.com/iiab/iiab/pull/2119#issuecomment-572083529)) so IIAB takes testing workflows seriously, which uphold our entire community.

* IIAB requests 3 separate files {install.yml, setup.yml, enable.yml AKA enable-or-disable.yml} that @jvonau just implemented across the most used IIAB playbooks, after extensive design discussions around Nov 2019.
And yes documentation needs to be readable too (OMG!) anyway thanks...just a quick summary of stuff needed as this PR #2119 hopefully stabilizes soon!

noted all.

I wasn't aware of the install/setup/enable/ triad (plus main). I did install/uninstall to keep things very simple just as i did with cham, but can change to this scheme. Anyway, more imp right now is to get all the steps in before figuring out how to split them :)

m-anish · 2020-01-08T19:44:39Z

iiab-admin@box:~ $ cat /etc/nginx/conf.d/nextcloud-nginx.conf
location /nextcloud {
proxy_pass http://127.0.0.1:8090/nextcloud;
}

location ~ /nextcloud/.*.php$ {
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $remote_addr;
proxy_set_header Host $host;
proxy_pass http://127.0.0.1:8090;
}

using the old template from uses_apache.yml

Fixed! 0285294

holta · 2020-02-17T02:39:44Z

@m-anish gets the credit for kicking this off. Now 5 weeks later, there's a need to polish & push this into production.

So I refined it within PR #2255 which I'm hoping can be merged very shortly now (e.g. in coming hours?) Even while it's not 100% perfect e.g. some Nextcloud's promo video doesn't play on 1st installation.

Still, this work should make for a big step forward, giving real options to the many communities globally that keep demanding a "DIY LMS" along the lines of Nextcloud/WordPress !

holta · 2020-02-17T18:31:03Z

@m-anish: I'm checked off 4 of your 8 boxes at the top of this ticket above based on PR #2255 now merged.

Next to the 4 remaining checkboxes, can you perhaps add a 5th checkbox for Nextcloud video(s) not displaying ?

(I've annotated this video/redirect problem within IIAB 7.1's Known Issues as well.)

holta · 2020-04-06T21:56:19Z

Progress here would be very welcome!

(But I'm moving this to IIAB 7.2's milestone as we have to release IIAB 7.1 in coming weeks.)

holta · 2020-09-10T01:37:43Z

Overtaken by events: roles/nextcloud is now remarkably solid, thanks to @floydianslips & others!

m-anish added 2 commits January 8, 2020 13:40

Initial stab at nextcloud running on nginx

4137c1d

Merge remote-tracking branch 'upstream/master' into nextcloud

8cbb22a

m-anish commented Jan 8, 2020

View reviewed changes

holta added the enhancement label Jan 8, 2020

holta added this to the 7.1 milestone Jan 8, 2020

m-anish commented Jan 8, 2020

View reviewed changes

m-anish mentioned this pull request Jan 8, 2020

http://box/nextcloud implemented natively with NGINX #2092

Closed

m-anish commented Jan 8, 2020

View reviewed changes

holta reviewed Jan 8, 2020

View reviewed changes

fix php-fpm service name restart in nextcloud playbook

34ae3e6

Update nginx config to reflect nextcloud not being proxied

0285294

holta assigned m-anish Jan 8, 2020

This was referenced Jan 8, 2020

NGINX: Nextcloud broken icons & broken links, erroneously contain http://127.0.0.1:8090 #2117

Closed

Validate Nextcloud 18.0.0 on release "2020-01-17" #2084

Closed

Failing/Short URL's—parent tkt to consolidate diverse issues #923

Closed

holta mentioned this pull request Feb 16, 2020

Nextcloud native on NGINX #2255

Merged

jvonau mentioned this pull request Feb 17, 2020

@m-anish plz help us come to a decision to get Nextcloud's php-* dependencies in place [non-php pkgs might also be added/removed?] #2258

Closed

This was referenced Feb 18, 2020

Nextcloud stores its data in /opt/ instead of /library/ #2021

Closed

Does nextcloud_allow_public_ips: False/True work with NGINX? #2108

Open

holta mentioned this pull request Mar 19, 2020

U20test / Ubuntu 20.04 to offer PHP 7.3 and 7.4 [Nextcloud PHP deps, php-stem on U20, ap0 prep, KA Lite on Ubermix, etc] #2294

Merged

holta modified the milestones: 7.1, 7.2 Apr 6, 2020

holta closed this Sep 10, 2020

holta mentioned this pull request Jun 27, 2021

Audit & Clean roles' PHP 7.x & 8.0 PHP module dependencies [MediaWiki, Moodle, MySQL, Nextcloud, NGINX, FreePBX] #2832

Merged

	- name: Nextcloud - Extract source {{ doc_root }}/{{ nextcloud_url }}
	- name: Nextcloud - Extract source {{ doc_root }}{{ nextcloud_url }}

Conversation

m-anish commented Jan 8, 2020 • edited by holta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-anish Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

m-anish Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

m-anish commented Jan 8, 2020

Uh oh!

holta commented Jan 8, 2020

Uh oh!

holta commented Jan 8, 2020

Uh oh!

m-anish commented Jan 8, 2020

Uh oh!

m-anish commented Jan 8, 2020

Uh oh!

m-anish Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

holta commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvonau commented Jan 8, 2020

Uh oh!

holta commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvonau commented Jan 8, 2020

Uh oh!

m-anish commented Jan 8, 2020

Uh oh!

holta commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

holta Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

m-anish commented Jan 8, 2020

Uh oh!

m-anish commented Jan 8, 2020

Uh oh!

holta commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

holta commented Feb 17, 2020

Uh oh!

holta commented Apr 6, 2020

Uh oh!

holta commented Sep 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

m-anish commented Jan 8, 2020 •

edited by holta

Loading

holta commented Jan 8, 2020 •

edited

Loading

holta commented Jan 8, 2020 •

edited

Loading

holta commented Jan 8, 2020 •

edited

Loading

holta commented Feb 17, 2020 •

edited

Loading