Support unknown 'type' values on bed trackline -- defauot to "annotat…#1981
Merged
Support unknown 'type' values on bed trackline -- defauot to "annotat…#1981
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for handling unknown track 'type' values on bed tracklines by defaulting to the "annotation" type. Key changes include:
- Adding a new test bed file with an unknown track type.
- Introducing the knownTrackTypes function in trackFactory.js to track registered types.
- Updating Browser logic to use the knownTrackTypes check and default to "annotation" if a type is unrecognized.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/data/bed/unknown_track_type.bed | Added test bed file with an unknown track type header |
| js/trackFactory.js | Added a knownTrackTypes function to expose valid track types |
| js/browser.js | Updated logic to default track type to "annotation" for unknowns |
| dev/annotation/unknownTrackType.html | Added demo HTML for testing annotation track behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jrobinso
added a commit
that referenced
this pull request
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion". See igvteam/igv-webapp#332