Conversion of objects to/from other libraries#242
Merged
ntamas merged 17 commits intoigraph:masterfrom Jul 14, 2020
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Member
|
FYI, this PR needs to be adjusted for the new directory structure ( |
Member
Author
|
I now adjusted the PR as requested and pulled in a fresh version of the |
Member
|
Yes, that's unrelated, it is also present on the master branch. I have to look into this at some point, I just haven't found the time to do so yet. |
ntamas
approved these changes
Jul 14, 2020
Member
|
Thanks a lot! The CI tests should now pass as I fixed the MSVC build error in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to address #237.
Done:
All these things include tests that pass locally. All tests on networkx pass on Travis too, but graph-tool is a pain to install there so that is not tested on CI.
This is ready for merging now