refactor(db): make Param class private #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The Param class has been renamed to _Param and is now private.
Contributor
Reviewer's GuideThe public Param class was refactored into a private _Param base class, and the InParam/OutParam classes were updated to derive from _Param with exports adjusted accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `incendium/src/incendium/db.py:44` </location>
<code_context>
+ type_code: Type code constant.
+ value: Value of type type_code.
+ """
+ super(_Param, self).__init__()
+ self._name_or_index = name_or_index
+ self._type_code = type_code
</code_context>
<issue_to_address>
The call to super().__init__() may be unnecessary if object is the only base.
You can remove the super().__init__() call here, as it has no effect unless you plan to support multiple inheritance in the future.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
super(_Param, self).__init__()
self._name_or_index = name_or_index
self._type_code = type_code
self._value = value
=======
self._name_or_index = name_or_index
self._type_code = type_code
self._value = value
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+44
to
+47
| super(_Param, self).__init__() | ||
| self._name_or_index = name_or_index | ||
| self._type_code = type_code | ||
| self._value = value |
Contributor
There was a problem hiding this comment.
suggestion: The call to super().init() may be unnecessary if object is the only base.
You can remove the super().init() call here, as it has no effect unless you plan to support multiple inheritance in the future.
Suggested change
| super(_Param, self).__init__() | |
| self._name_or_index = name_or_index | |
| self._type_code = type_code | |
| self._value = value | |
| self._name_or_index = name_or_index | |
| self._type_code = type_code | |
| self._value = value |
cesarcoatl
added a commit
that referenced
this pull request
Sep 4, 2025
stubs now also include `db._Param` from #272 Co-authored-by: lokomoti <40903296+lokomoti@users.noreply.github.com> Co-authored-by: César Román <cesar@coatl.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The Param class has been renamed to _Param and is now private.
Summary by Sourcery
Enhancements: