refactor(util): move functions out of util #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make project installable on Jython add devcontainer add Jython install tests BREAKING CHANGE: deprecate incendium.util functions
Contributor
There was a problem hiding this comment.
Hey @cesarcoatl - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -1,3 +1,4 @@ | |||
| # pylint: disable=implicit-str-concat | |||
Contributor
There was a problem hiding this comment.
suggestion (testing): Consider removing deprecated functions from util.py
The functions get_function_name, get_timer, and get_timestamp have been marked as deprecated and moved to other modules. It's recommended to remove these from util.py to avoid redundancy and potential confusion.
cesarcoatl
added a commit
that referenced
this pull request
Oct 28, 2024
ref: #199 BREAKING CHANGE: util module has been removed
cesarcoatl
added a commit
that referenced
this pull request
Oct 28, 2024
ref: #199 BREAKING CHANGE: util module has been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
pre-commit run --all-filestoxtests have succeededPR Type
What kind of change does this PR introduce?
What is the current behavior?
This project is only installable using Python.
Issue Number: N/A
What is the new behavior?
Make it installable using Jython.
Does this PR introduce a breaking change?
deprecate incendium.util functions
Other information