Conversation
baggiiiie
reviewed
Mar 14, 2026
Collaborator
baggiiiie
left a comment
There was a problem hiding this comment.
nice! didnt expect this will require such big change
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 17, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.10.1` → `v0.10.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.10.2`](https://github.com/idursun/jjui/releases/tag/v0.10.2) [Compare Source](idursun/jjui@v0.10.1...v0.10.2) Quick release to continue the release early, release often streak. ##### Features - **Custom diff and preview content** — You can now use `diff.show()` and `ui.preview.show()` in your Lua actions to display custom command output in the diff and preview panels. ([#​593](idursun/jjui#593)) ##### Bug Fixes - **Rebase source + insert between** — Rebase now correctly uses `-s` (source) instead of `-r` when combining source mode with insert-between. ([#​598](idursun/jjui#598)) - **Missing actions in status bar** — Actions with the same name in different scopes (e.g. `revset.edit` and `revisions.edit`) are no longer hidden from the status bar. ([#​595](idursun/jjui#595)) - **Misaligned lines across terminals** — Terminals handle Unicode width calculation differently — Ghostty enables grapheme clustering by default while Kitty does not. We now detect the terminal's width mode and calculate widths accordingly, fixing rendering in both. ([#​592](idursun/jjui#592)) - **Operation action overrides** — Some built-in actions during operations couldn't be overridden in `config.lua`. For example, `revisions.details.diff`, `revisions.evolog.diff`, and `revisions.rebase.*` actions can now be properly overridden. ([#​586](idursun/jjui#586), [#​598](idursun/jjui#598)) #### What's Changed - fix(render): detect terminal width method by [@​idursun](https://github.com/idursun) in [#​592](idursun/jjui#592) - feat: add diff and preview show intents by [@​idursun](https://github.com/idursun) in [#​593](idursun/jjui#593) **Full Changelog**: <idursun/jjui@v0.10.1...v0.10.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My43Ny4wIiwidXBkYXRlZEluVmVyIjoiNDMuNzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes misaligned lines in terminals that use grapheme clustering by default, such as Ghostty, while preserving correct rendering in terminals like Kitty that do not.
We detect terminal support for Unicode core width mode by listening for
tea.ModeReportMsg, then we store the detected width method into therenderpackage. I movedWidthmethods to the render package so that it is consistent across the codebase (by using the detected width method).I tested it on both terminals and seems to be rendering correctly.