feat: add `(` to functions when autocompleted by nickchomey · Pull Request #564 · idursun/jjui

nickchomey · 2026-02-28T21:41:40Z

I finally decided to use AI to help me make changes to jjui (along with using jjui itself to navigate the different branches etc to test out new functionality)!

A small first PR: when you autocomplete ta it'll fill tags( with the opening (. functions like all still autocomplete as all()

It was, of course, an easy and seamless experience. Looking forward to contributing more in the future!

Copilot

Pull request overview

This PR adjusts revset autocomplete formatting so functions that take parameters are completed with an opening parenthesis (e.g., tags(), while parameterless functions continue to complete with () (e.g., all()).

Changes:

Update source.Item.DisplayName() to append ( for functions with parameters and () for parameterless functions.
Update revset completion tests to expect ( for parameterized functions (ancestors, author).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
internal/ui/revset/completion_provider_test.go	Updates completion expectations for parameterized functions to include `(`.
internal/jj/source/source.go	Changes how function completion display names are rendered based on whether they have parameters.

Comments suppressed due to low confidence (1)

internal/ui/revset/completion_provider_test.go:66

The updated completion behavior is only asserted for a couple of parameterized functions (ancestors/author). Since the PR description calls out both parameterized (e.g., tags) and parameterless functions (e.g., all), consider adding test cases that explicitly assert: (1) a parameterized function like tags completes to tags(, and (2) a parameterless function like all still completes to all() to guard against regressions in Item.DisplayName().

func TestGetCompletions(t *testing.T) {
	tests := []struct {
		input    string
		expected string
	}{
		{"ancestors", "ancestors("},
		{"ancestors(visible_", "visible_heads()"},
		{"author", "author("},
		{"author(m", "mine()"},
		{"author( m", "mine()"},
		{"present(@) | m", "mine()"},
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nickchomey · 2026-02-28T21:44:45Z

One question: should it show the opening parenthesis in the list of functions? Alternatively, should the () be removed from all() etc...?

idursun

Hey thanks!

Showing ( next to the function name looks odd but technically makes sense. I'd prefer showing the function name as is and () or ( only when they are selected.

Normally, I implement both then go with the one that feels the most natural.

I am happy to merge this one as this is more correct than what we currently have.

nickchomey · 2026-03-01T02:07:58Z

ah, yes. of course. Fixed in #567

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | minor | `v0.9.12` → `v0.10.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.10.0`](https://github.com/idursun/jjui/releases/tag/v0.10.0) [Compare Source](idursun/jjui@v0.9.12...v0.10.0) Wow, a major release after a very long time. As promised, `v0.10` is ready, and it comes with **breaking changes**. First, thank you to everybody who contributed code, bug reports, ideas, and testing for this release. In particular, thanks to [@baggiiiie](https://github.com/baggiiiie) for various features and fixes, [@nickchomey](https://github.com/nickchomey) for contributions and continuous feedback, and [@vic](https://github.com/vic) for updating the documentation website. Thanks as well to everyone else for various code contributions, reporting issues, and verifying fixes. We changed a lot in `v0.10`, but the biggest shift is that we finally got rid of some **legacy configuration** and moved to a unified **actions + bindings** model. Old concepts like `[custom_commands]` and `[leader]` are now replaced by a more consistent system built around **actions**, **bindings**, and first-class support for leader-style key sequences. This release also introduces `config.lua`, which makes it much easier to customise and extend `jjui` with **real scripting** instead of only static configuration. Between `config.toml`, `config.lua`, Lua actions, and bindings, much more of the UI can now be customised in one consistent way. The documentation has been updated with [**migration notes**](https://idursun.github.io/jjui/migrating/v0_10/) and examples such as the [**Lua Cookbook**](https://idursun.github.io/jjui/lua-cookbook/). From my testing it looks ready, but I am sure more rough edges will show up once more people start using it, so please keep reporting issues as you find them. #### ⚠️ Breaking Changes `v0.10` replaces the **legacy keybinding and customisation model** with the new **actions + bindings** system. - `[keys]` configuration is no longer used. - `[custom_commands]` is replaced by `[[actions]]` and `[[bindings]]`. - `[leader]` sequences are replaced by sequence bindings via `seq`. If you have an existing configuration, plan to **migrate it** rather than expecting a drop-in upgrade from `v0.9.x`. #### ✨Highlights - **Unified actions + bindings system.** Keyboard input now flows through a single dispatch pipeline, default bindings are declared in TOML, actions are discoverable, and custom behaviour can be defined in both TOML and Lua. - **Much stronger scripting support.** Lua `setup` now receives the full config plus runtime context, generated intent-backed actions replace handwritten drift-prone bridges, and new helpers like `wait_close()` and `wait_refresh()` make multi-step scripts more predictable. - **Upgraded TUI foundations.** Moving from **Bubble Tea v1** to **v2** brings better terminal support, a new rendering engine for better performance, and better input handling, including support for bindings like `ctrl+space` and dedicated `shift+...` style keys. - **Improved diff and selection workflows.** The `diff` view now supports word wrap, `revisions` and `details` support modifier-based mouse selection, and several `details` and `evolog` interactions are more consistent. #### 🚀 New and Improved ##### Command History - Added [**command history**](https://idursun.github.io/jjui/command-history/), available with `shift+w`, to review dismissed command runs together with their output. - Moved **running command** information out of the status area and into dedicated `flash` messages, so the command and its output are now shown together in one place. ##### Help and Status - Reintroduced a dedicated **Help view** for full keybinding discovery, with filtering and scrolling, alongside the existing inline help. - Changed **status/help** binding presentation to **column-major order** so related bindings are easier to scan. ##### Lua and Configuration - Shipped the unified **actions + bindings** architecture introduced in `v0.10`. - Exposed the full config object to Lua `setup`, including runtime context such as repository path via `config.repo`, and terminal state via `config.terminal.dark_mode`, `config.terminal.fg`, and `config.terminal.bg`. - Standardised closeable action naming around `open_*` and aligned apply/close semantics for more predictable scripted workflows. ##### Oplog - Added **quick search** to `oplog` and shared the search behavior with revision search. ##### Evolog - Changed `evolog` preview defaults to show **interdiff** output, matching `jj evolog -p` more closely. ##### Abandon - Added `s` in `abandon` mode to target descendants of the selected revision(s). ##### Revset - Kept `revset` editing open when the expression is invalid, improving iteration while editing. - Improved `revset` editing so function completion inserts `(` when appropriate, while the function list display is cleaner and less noisy. ##### Diff - Added **word wrap** in the `diff` view, with explicit wrapped and unwrapped modes plus soft-wrap-aware scrolling. - Added `g` and `G` in the `diff` view to jump to the top and bottom. ##### Details and Revisions - Added `Ctrl+click` single-item toggle and `Alt+click` range selection in `revisions` and `details`. - Added a `revisions.details.select_file` action for finer control in `details` workflows. #### 🛠️ Fixes - Fixed rendering issues with **double-width characters**. - Simplified divergent revision handling by using `change_id/offset` directly from the `jj log` prefix template. - Fixed `git push --all` behaviour for deleted bookmarks and corrected related command descriptions. #### ⚙️ Internal Updates - Upgraded to **Bubble Tea v2**. - Replaced remaining `cellbuf` usage with `ultraviolet`. - Hardcoded model-level key handling has been removed in favor of dispatcher-driven intents. - Continued internal cleanup around rendering, overlays, display context, and generated action plumbing to support the new architecture. #### What's Changed - Unified Actions + Bindings system by [@idursun](https://github.com/idursun) in [#533](idursun/jjui#533) - feat(oplog): add QuickSearch to oplog, share logic with revision search by [@baggiiiie](https://github.com/baggiiiie) in [#521](idursun/jjui#521) - fix: add missing keys in bindings by [@baggiiiie](https://github.com/baggiiiie) in [#538](idursun/jjui#538) - feat(evolog): change default evolog command to show interdiff by [@academician](https://github.com/academician) in [#539](idursun/jjui#539) - fix: add back `esc` to clear checked revisions by [@baggiiiie](https://github.com/baggiiiie) in [#541](idursun/jjui#541) - remove gh-pages workflow from main branch. by [@vic](https://github.com/vic) in [#542](idursun/jjui#542) - docs: fix readme links by [@baggiiiie](https://github.com/baggiiiie) in [#549](idursun/jjui#549) - Update CONTRIBUTING.md for documentation by [@vic](https://github.com/vic) in [#547](idursun/jjui#547) - feat(lua): add "filter" and "ordered" option to `choose` lua api by [@baggiiiie](https://github.com/baggiiiie) in [#548](idursun/jjui#548) - feat(abandon): use `s` for selecting descendants by [@idursun](https://github.com/idursun) in [#544](idursun/jjui#544) - feat: add change\_offset in jj log prefix template for divergent revisions by [@baggiiiie](https://github.com/baggiiiie) in [#550](idursun/jjui#550) - fix: make bookmark input visible when user has custom template-aliases by [@baggiiiie](https://github.com/baggiiiie) in [#551](idursun/jjui#551) - fix(evolog): keep restore mode navigation on revisions and esc close by [@baggiiiie](https://github.com/baggiiiie) in [#554](idursun/jjui#554) - Expose full config to Lua setup and add runtime context (repo + terminal) by [@idursun](https://github.com/idursun) in [#553](idursun/jjui#553) - feat(flash): command history by [@idursun](https://github.com/idursun) in [#556](idursun/jjui#556) - Update to bubbletea v2 by [@idursun](https://github.com/idursun) in [#558](idursun/jjui#558) - Ctrl+click and Alt+click for single and range selection by [@idursun](https://github.com/idursun) in [#563](idursun/jjui#563) - feat: add `(` to functions when autocompleted by [@nickchomey](https://github.com/nickchomey) in [#564](idursun/jjui#564) - feat(status): change display to column major order by [@baggiiiie](https://github.com/baggiiiie) in [#569](idursun/jjui#569) - fix: remove parentheses from functions list, but add when autocomplete by [@nickchomey](https://github.com/nickchomey) in [#567](idursun/jjui#567) - fix(git): prevent panic when opening git menu with no selected revision by [@baggiiiie](https://github.com/baggiiiie) in [#571](idursun/jjui#571) - Refactor/Lua bridge by [@idursun](https://github.com/idursun) in [#572](idursun/jjui#572) - fix(ui): guard against nil commit in OpenBookmarks intent by [@baggiiiie](https://github.com/baggiiiie) in [#573](idursun/jjui#573) - feat(diff): word wrap by [@idursun](https://github.com/idursun) in [#575](idursun/jjui#575) - Add pgup/pgdown keybindings to evolog and details by [@academician](https://github.com/academician) in [#576](idursun/jjui#576) - feat(lua): make default actions overridable and expose jjui.builtin.\* by [@idursun](https://github.com/idursun) in [#577](idursun/jjui#577) - feat(help): add "help view" bound to `f1` by [@idursun](https://github.com/idursun) in [#578](idursun/jjui#578) #### New Contributors - [@academician](https://github.com/academician) made their first contribution in [#539](idursun/jjui#539) **Full Changelog**: <idursun/jjui@v0.9.12...v0.10.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

feat: add ( to functions when autocompleted

dfa6236

Copilot AI review requested due to automatic review settings February 28, 2026 21:41

nickchomey requested a review from idursun as a code owner February 28, 2026 21:41

Copilot started reviewing on behalf of nickchomey February 28, 2026 21:42 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

idursun approved these changes Feb 28, 2026

View reviewed changes

idursun merged commit f2c7550 into idursun:main Feb 28, 2026
7 of 8 checks passed

BrewTestBot mentioned this pull request Mar 8, 2026

jjui 0.10.0 Homebrew/homebrew-core#271272

Merged

nickchomey deleted the autocomplete-w-parenthesis branch March 22, 2026 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `(` to functions when autocompleted#564

feat: add `(` to functions when autocompleted#564
idursun merged 1 commit intoidursun:mainfrom
nickchomey:autocomplete-w-parenthesis

nickchomey commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

nickchomey commented Feb 28, 2026

Uh oh!

idursun left a comment

Uh oh!

Uh oh!

nickchomey commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nickchomey commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

nickchomey commented Feb 28, 2026

Uh oh!

idursun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nickchomey commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickchomey commented Feb 28, 2026 •

edited

Loading