feat(lua): add ability to await on operation results (cancelled/applied) by idursun · Pull Request #422 · idursun/jjui

idursun · 2025-12-12T22:22:45Z

This PR updates the lua bridge to know if an operation has been applied or cancelled. This will allow #310 to be implemented like the following:

[custom_commands."inline commit"]
  key_sequence = ["w", "x"]
  lua = '''
  if revisions.start_inline_describe() then
    jj("new")
  end
  '''

A new revision is created only if the user pressed apply (i.e. alt+enter)

I’ll gradually apply the same approach to the remaining operations.

fixes #310

baggiiiie

nice!

OliverJAsh · 2025-12-14T07:42:41Z

This is great @idursun 👏

I noticed your command doesn't move the cursor to the new commit. How would I go about doing that?

idursun · 2025-12-14T09:43:48Z

You can move to any commit using:

revisions.navigate { to = <change id goes here> }

Having said that though, in my case, it is automatically moving to @ already. Is it staying on the same revision and not moving to the new one in your case?

OliverJAsh · 2025-12-14T15:19:23Z

I had to make a small change to make sure the new commit is inserted on top of the same commit that was just described (rather than the current working copy commit which might be a different commit):

[custom_commands."inline commit"]
  key_sequence = ["w", "x"]
  lua = '''
  if revisions.start_inline_describe() then
    jj("new", revisions.current())
  end
  '''

idursun · 2025-12-14T15:26:08Z

Ah, I see. Then the following should work I think:

[custom_commands."inline commit"]
  key_sequence = ["w", "x"]
  lua = '''
  if revisions.start_inline_describe() then
    jj("new", revisions.current())
    revisions.navigate { to = "@" }
  end
  '''

OliverJAsh · 2025-12-14T16:47:23Z

When I run this on a selected commit that is not the working copy commit, the navigate call seems to interfere with the inline describe:

Screen.Recording.2025-12-14.at.16.46.52.mov

idursun · 2025-12-14T19:42:47Z

@OliverJAsh are you on the main branch or on 0.9.8? This only works on the main branch for now. I haven't released it yet.

I added refresh after new to correctly navigate to the new commit, seems to be working just fine on main.

[custom_commands."inline commit"]
  key_sequence = ["w", "x"]
  lua = '''
  if revisions.start_inline_describe() then
    jj("new", revisions.current())
    revisions.refresh()
    revisions.navigate { to = "@" }
  end
  '''

OliverJAsh · 2025-12-14T19:49:46Z

I'm using 0.9.8, I will wait for the next release, thanks!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.9.8` → `v0.9.9` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.9.9`](https://github.com/idursun/jjui/releases/tag/v0.9.9) [Compare Source](idursun/jjui@v0.9.8...v0.9.9) ### Release Notes Another release with small improvements and bug fixes. Thanks to all contributors! #### 🎉 New Features ##### Custom Commands & Lua API Enhancements - **Custom Commands with Sequence Keys** ([#420](idursun/jjui#420)) - Added `key_sequence` property allowing custom commands to be invoked with multiple key presses in sequence - Added `desc` property for command descriptions - Introduced sequence overlay UI showing available key sequences when first key is pressed - Example: `key_sequence = ["w", "b", "l"]` - **Lua API: Choose Method and UI** ([#427](idursun/jjui#427)) ([#442](idursun/jjui#442)) - New `choose()` function for interactive selection prompts in Lua scripts - New `input()` function to prompt users for text input with customizable title and prompt - New `split_lines()` function for text processing - **Lua API: Await on Operation Results** ([#422](idursun/jjui#422)) - `start_inline_describe()` now returns boolean indicating if operation was applied or cancelled - Enables conditional command execution based on user actions - Fixes [#310](idursun/jjui#310) - **Lua API: Interactive Commands** ([commit 8b257263](idursun/jjui@8b257263)) - Added `jj_interactive` Lua function for interactive jj command execution ##### Navigation & UI Improvements - **Ace Jump for Operations** ([#445](idursun/jjui#445)) - Pressing 'f' in set\_parents/duplicate/rebase/squash modes now triggers ace jump - After jump completes, returns to the original operation mode instead of normal mode - Closes [#394](idursun/jjui#394) - **Preview Width Variable** ([#452](idursun/jjui#452)) - Added `$preview_width` placeholder variable for preview commands - Exposes actual view width (in columns) to enable tools like delta to use `--side-by-side` correctly - Width updates dynamically when preview pane is resized - Similar to fzf's `$FZF_PREVIEW_COLUMNS` - **Configurable Flash Message Display Time** ([#456](idursun/jjui#456)) - New config key: `ui.flash_message_display_seconds` (default: 4) - Special value `0` means messages display until manually dismissed - Fixes [#455](idursun/jjui#455) - **Page Up/Down Key Configuration** ([#437](idursun/jjui#437)) - ScrollUp/Down keys now registered in config instead of hardcoded - Keys exposed to configuration for customization - Fixes [#360](idursun/jjui#360) ##### SSH & Authentication - **SSH Askpass Support** ([#423](idursun/jjui#423)) - New `[ssh] hijack_askpass` setting to prompt for SSH passphrases/PINs within jjui - Works on Linux and macOS - Properly handles prompt overriding and cancellation - Fixes [#100](idursun/jjui#100) #### 🐛 Bug Fixes - **Exec Command History** ([#458](idursun/jjui#458)) - Fixed issue where selected command history wasn't applied in exec mode - Input value now properly updated when selecting from fuzzy/regex suggestions - Selected commands correctly saved to history - **Menu Pagination Display** ([#446](idursun/jjui#446)) - Fixed incorrect `%d/%d` pagination display - Height now calculated before pagination render - Added tab/shift+tab to short help menu - Fixes [#444](idursun/jjui#444) - **Flash Message Width** ([#432](idursun/jjui#432)) - Added maxWidth (50% of screen) to flash message rendering - Messages now properly line-wrap instead of extending beyond window width - **Operation Log Refresh** ([#431](idursun/jjui#431)) - Operation log now returns Refresh and SelectionChanged messages upon closing - Fixes [#430](idursun/jjui#430) - **Custom Commands List Sorting** ([commit 3fa9783a](idursun/jjui@3fa9783a)) - Fixed custom commands list to use stable sort - Fixes [#424](idursun/jjui#424) - **JJ Error Pass-through** ([#421](idursun/jjui#421)) - jjui now properly passes through stderr from jj commands - Error messages are more informative and show actual jj errors - **Navigation Message Display** ([commit 94a4a874](idursun/jjui@94a4a874)) - Navigation messages now only shown for paged scrolls #### What's Changed - main: pass through jj error by [@baggiiiie](https://github.com/baggiiiie) in [#421](idursun/jjui#421) - feat(lua): add ability to await on operation results (cancelled/applied) by [@idursun](https://github.com/idursun) in [#422](idursun/jjui#422) - oplog: return Refresh and SelectionChanged upon oplog closing by [@baggiiiie](https://github.com/baggiiiie) in [#431](idursun/jjui#431) - feat(nix): add comprehensive nix flake by [@doprz](https://github.com/doprz) in [#426](idursun/jjui#426) - Add option to hijack SSH Askpass to prompt for passphrase/pin by [@oliverpool](https://github.com/oliverpool) in [#423](idursun/jjui#423) - feat(lua): add choose method and ui by [@idursun](https://github.com/idursun) in [#427](idursun/jjui#427) - flash: add maxWidth to flash msg rendering by [@baggiiiie](https://github.com/baggiiiie) in [#432](idursun/jjui#432) - keys: add pageup/down to keys config by [@baggiiiie](https://github.com/baggiiiie) in [#437](idursun/jjui#437) - chore(github): Add Adda0 as an automatic reviewer for Nix-related changes by [@Adda0](https://github.com/Adda0) in [#440](idursun/jjui#440) - feat: add .editorconfig by [@doprz](https://github.com/doprz) in [#434](idursun/jjui#434) - Add input and log to custom\_commands API by [@ArnaudBger](https://github.com/ArnaudBger) in [#442](idursun/jjui#442) - oplog,list: refactor scrolling with Scrollable/StreamableList interface by [@baggiiiie](https://github.com/baggiiiie) in [#429](idursun/jjui#429) - menu: calculate height before pagination render by [@baggiiiie](https://github.com/baggiiiie) in [#446](idursun/jjui#446) - operations: enable ace jump for set\_parents/duplicate/rebase/squash by [@baggiiiie](https://github.com/baggiiiie) in [#445](idursun/jjui#445) - feat: make flash message display time configurable by [@living180](https://github.com/living180) in [#456](idursun/jjui#456) - feat: add $width variable for preview commands by [@pablospe](https://github.com/pablospe) in [#452](idursun/jjui#452) - status: fix exec command history not applied by [@baggiiiie](https://github.com/baggiiiie) in [#458](idursun/jjui#458) #### New Contributors - [@doprz](https://github.com/doprz) made their first contribution in [#426](idursun/jjui#426) - [@oliverpool](https://github.com/oliverpool) made their first contribution in [#423](idursun/jjui#423) - [@living180](https://github.com/living180) made their first contribution in [#456](idursun/jjui#456) - [@pablospe](https://github.com/pablospe) made their first contribution in [#452](idursun/jjui#452) **Full Changelog**: <idursun/jjui@v0.9.8...v0.9.9> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

feat(lua): await on start_inline_describe

ae8a058

baggiiiie reviewed Dec 13, 2025

View reviewed changes

idursun merged commit 354fa92 into main Dec 13, 2025
3 checks passed

idursun deleted the await-on-operation-result branch December 13, 2025 08:31

BrewTestBot mentioned this pull request Jan 9, 2026

jjui 0.9.9 Homebrew/homebrew-core#261935

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lua): add ability to await on operation results (cancelled/applied)#422

feat(lua): add ability to await on operation results (cancelled/applied)#422
idursun merged 1 commit intomainfrom
await-on-operation-result

idursun commented Dec 12, 2025 •

edited

Loading

Uh oh!

baggiiiie left a comment

Uh oh!

Uh oh!

OliverJAsh commented Dec 14, 2025 •

edited

Loading

Uh oh!

idursun commented Dec 14, 2025

Uh oh!

OliverJAsh commented Dec 14, 2025

Uh oh!

idursun commented Dec 14, 2025

Uh oh!

OliverJAsh commented Dec 14, 2025

Uh oh!

idursun commented Dec 14, 2025

Uh oh!

OliverJAsh commented Dec 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

idursun commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baggiiiie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OliverJAsh commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idursun commented Dec 14, 2025

Uh oh!

OliverJAsh commented Dec 14, 2025

Uh oh!

idursun commented Dec 14, 2025

Uh oh!

OliverJAsh commented Dec 14, 2025

Uh oh!

idursun commented Dec 14, 2025

Uh oh!

OliverJAsh commented Dec 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

idursun commented Dec 12, 2025 •

edited

Loading

OliverJAsh commented Dec 14, 2025 •

edited

Loading