jj-update: fix commands to work with breaking changes in jj-0.36.0 by baggiiiie · Pull Request #407 · idursun/jjui

baggiiiie · 2025-12-04T15:46:01Z

in Release v0.36.0 - jj-vcs/jj, jj has breaking changes which breaks jjui.

Below is the fixes for:

deprecation of --destination flag: changed to --onto
deprecation of --edit flag: changed to --editor
deprecation of --allow-new flag for git push: removed all commands calling git push with --allow-new

baggiiiie · 2025-12-04T15:48:17Z

internal/jj/bookmark_parser.go

-func (b Bookmark) IsPushable() bool {
-	return b.Local != nil && len(b.Remotes) == 0
-}
-


Bookmark.Pushable now becomes used in the codebase 😔

idursun · 2025-12-05T21:23:51Z

Hey, thanks!

If we merge this now, we will force everybody to be on 0.36, otherwise jjui won't work for them. Since 0.36 just came out, I would like to take advantage of the deprecation period for a little longer so that when this lands majority of the users would be on that version. I hope you don't mind this PR staying open for some time.

Additionally, we need to update the minimum jj version in the README.md to 0.36.

nickchomey · 2025-12-05T21:32:14Z

I'm not sure anyone wins if this is merged or if you wait an arbitrary while.

Perhaps the fixes can be put behind some sort of flag/version check?

idursun · 2025-12-06T00:59:23Z

I'm not sure anyone wins if this is merged or if you wait an arbitrary while.

jj has been released just yesterday. I still want to keep my option to release another version of jjui that doesn't break for folks who are still on 0.35 or before. I sometimes update to the latest jj version a few weeks after its release.

Perhaps the fixes can be put behind some sort of flag/version check?

Yes, but it's only worthwhile if implementing a version check and branching the code per jj version takes less than a couple of weeks.

baggiiiie · 2025-12-06T06:46:46Z

I hope you don't mind this PR staying open for some time.

@idursun hey it's fine, let's wait for a while
also i have updated the readme to have minimum requirement of jj 0.36

some sort of flag/version check?
handling backward compatibility is always a pain, since jj already has breaking changes, i think it's reasonable that jj's breaking changes propagate and become jjui's breaking changes

doprz · 2025-12-18T02:12:43Z

I'm not sure anyone wins if this is merged or if you wait an arbitrary while.

jj has been released just yesterday. I still want to keep my option to release another version of jjui that doesn't break for folks who are still on 0.35 or before. I sometimes update to the latest jj version a few weeks after its release.

Perhaps the fixes can be put behind some sort of flag/version check?

Yes, but it's only worthwhile if implementing a version check and branching the code per jj version takes less than a couple of weeks.

I'm using jj v0.36.0 and although these commands are deprecated they still work albeit with a warning and what the correct syntax is moving forward. We could add a backwards compatibility flag or simply wait until jj makes a new release that removes these warnings/compatabilty layer in which then we would up jjui's minimum jj version to v0.36.0+.

in [Release v0.36.0 - jj-vcs/jj](https://github.com/jj-vcs/jj/releases/tag/v0.36.0), jj has breaking changes which breaks jjui. This commit includes the fixes for: - deprecation of `--destination` flag: changed to `--onto` - deprecation of `--edit` flag: changed to `--editor` - deprecation of `--allow-new` flag for `git push`: removed all commands calling `git push` with `--allow-new` Additionally, to replace `d` for `--destination`, `o` is used for the new `--onto` flag in related modes, which conflicts with OpLog.Mode. Hence, a `IsNormalMode` check is added to ui.

nickchomey · 2026-01-08T10:12:32Z

0.37.0 is now out. Looking through the changelog, not sure what affects jjui but there's a lot of welcomed changes.

https://github.com/jj-vcs/jj/releases/tag/v0.37.0

baggiiiie · 2026-01-08T15:47:10Z

@nickchomey yeap didn't see anything that might affect jjui
i have upgraded to 0.37.0 and been using it for the whole day, didn't have any issue

nickchomey · 2026-01-08T15:51:05Z

Are you running this PR branch then? Because not being able to use destination affects rebasing etc

baggiiiie · 2026-01-09T01:41:49Z

Because not being able to use destination affects rebasing etc

@nickchomey ah this should have been brought up in this PR, my bad!
since --destination is now --onto in jj 0.36.0+, i updated the keybinding for -d from d to o

@idursun please be aware of this behavior change, and advise if any changes needed

idursun

Thanks @baggiiiie I think this is good to go in.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.9.9` → `v0.9.10` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.9.10`](https://github.com/idursun/jjui/releases/tag/v0.9.10) [Compare Source](idursun/jjui@v0.9.9...v0.9.10) ### Release Notes #### 🆕 Features ##### Lua Scripting Enhancements - **Lua Context Module** ([#465](idursun/jjui#465)): Added context module to Lua scripting API, exposing methods for accessing selected item metadata and checked items: - `context.change_id()` - Get the change ID of selected revision or file - `context.commit_id()` - Get the commit ID of selected revision, file, or commit - `context.file()` - Get the file path of selected file - `context.operation_id()` - Get the operation ID of selected operation - `context.checked_files()` - Get array of checked file paths - `context.checked_change_ids()` - Get array of change IDs from checked items - `context.checked_commit_ids()` - Get array of commit IDs from checked items - **Shell Execution in Lua** ([#471](idursun/jjui#471)): Exposed `exec_shell()` function to Lua scripts, enabling interactive commands like opening files in external editors directly from jjui. This enables custom commands such as: ```toml [custom_commands.open_file] key = ["O"] lua = ''' local file = context.file() if not file then flash("No file selected") return end exec_shell("vim " .. file) ''' ``` #### ✨ Improvements - **Abandon Workflow**: Removed confirmation dialog; users can now use Space to add/remove revisions from the abandon list #### 🐛 Bug Fixes - **Preview Pane Scrolling** ([#472](idursun/jjui#472)): Fixed broken Ctrl-U/Ctrl-D scrolling in the preview pane that was introduced by earlier input routing changes. Preview commands are now properly grouped and always handled. - **Parser**: Fixed handling of divergent change ID format - **Bookmarks**: Fixed tracking of new bookmarks (currently tracks all remotes) #### 🔧 Compatibility - **Jujutsu 0.36.0 Support** ([#407](idursun/jjui#407)): Updated commands to work with breaking changes in Jujutsu 0.36.0: - Changed `--destination` flag to `--onto` - Changed `--edit` flag to `--editor` - Removed deprecated `--allow-new` flag from `git push` commands - Updated keybinding from `d` to `o` for `--onto` flag in related modes #### 📝 Documentation - **README Updates** ([#470](idursun/jjui#470)): - Added missing op log revert item to help menu - Fixed redo documentation - Updated custom command examples #### What's Changed - jj-update: fix commands to work with breaking changes in jj-0.36.0 by [@baggiiiie](https://github.com/baggiiiie) in [#407](idursun/jjui#407) - refactor(abandon): remove confirmation dialog by [@idursun](https://github.com/idursun) in [#462](idursun/jjui#462) - fix(bookmarks): track new bookmarks by [@idursun](https://github.com/idursun) in [#463](idursun/jjui#463) - feat(lua): add context module by [@idursun](https://github.com/idursun) in [#465](idursun/jjui#465) - lua: expose exec\_shell to lua script by [@baggiiiie](https://github.com/baggiiiie) in [#471](idursun/jjui#471) - README improvements and help menu missing item by [@baggiiiie](https://github.com/baggiiiie) in [#470](idursun/jjui#470) - ui,preview: fix preview pane ctrl-u/d scrolling by [@baggiiiie](https://github.com/baggiiiie) in [#472](idursun/jjui#472) **Full Changelog**: <idursun/jjui@v0.9.9...v0.9.10> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

baggiiiie force-pushed the yc/jj-breaking-change branch from a0a5a72 to 61f3e7d Compare December 4, 2025 15:47

baggiiiie commented Dec 4, 2025

View reviewed changes

baggiiiie force-pushed the yc/jj-breaking-change branch from 61f3e7d to 275998c Compare December 6, 2025 06:42

baggiiiie force-pushed the yc/jj-breaking-change branch 2 times, most recently from 4b0e7c4 to b2daa9e Compare December 11, 2025 06:07

baggiiiie force-pushed the yc/jj-breaking-change branch from b2daa9e to 8f0686a Compare December 19, 2025 11:13

baggiiiie requested a review from idursun as a code owner December 19, 2025 11:13

baggiiiie force-pushed the yc/jj-breaking-change branch from 8f0686a to 9a2d64a Compare January 4, 2026 11:49

idursun mentioned this pull request Jan 9, 2026

fix: replace deprecated --edit with --editor in describe command #460

Closed

idursun approved these changes Jan 9, 2026

View reviewed changes

idursun merged commit 2809358 into idursun:main Jan 9, 2026
4 checks passed

idursun mentioned this pull request Jan 9, 2026

fix(bookmarks): track new bookmarks #463

Merged

baggiiiie deleted the yc/jj-breaking-change branch January 12, 2026 01:10

BrewTestBot mentioned this pull request Jan 17, 2026

jjui 0.9.10 Homebrew/homebrew-core#263342

Merged

oliverpool mentioned this pull request Jan 30, 2026

jjui: jujutsu 0.36.0 is required for jjui 0.9.10, but stable provides only 0.35.0 NixOS/nixpkgs#485249

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jj-update: fix commands to work with breaking changes in jj-0.36.0#407

jj-update: fix commands to work with breaking changes in jj-0.36.0#407
idursun merged 1 commit intoidursun:mainfrom
baggiiiie:yc/jj-breaking-change

baggiiiie commented Dec 4, 2025

Uh oh!

baggiiiie Dec 4, 2025

Uh oh!

idursun commented Dec 5, 2025

Uh oh!

nickchomey commented Dec 5, 2025

Uh oh!

idursun commented Dec 6, 2025 •

edited

Loading

Uh oh!

baggiiiie commented Dec 6, 2025

Uh oh!

doprz commented Dec 18, 2025

Uh oh!

nickchomey commented Jan 8, 2026

Uh oh!

baggiiiie commented Jan 8, 2026

Uh oh!

nickchomey commented Jan 8, 2026

Uh oh!

baggiiiie commented Jan 9, 2026

Uh oh!

idursun left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

baggiiiie commented Dec 4, 2025

Uh oh!

baggiiiie Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

idursun commented Dec 5, 2025

Uh oh!

nickchomey commented Dec 5, 2025

Uh oh!

idursun commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baggiiiie commented Dec 6, 2025

Uh oh!

doprz commented Dec 18, 2025

Uh oh!

nickchomey commented Jan 8, 2026

Uh oh!

baggiiiie commented Jan 8, 2026

Uh oh!

nickchomey commented Jan 8, 2026

Uh oh!

baggiiiie commented Jan 9, 2026

Uh oh!

idursun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

idursun commented Dec 6, 2025 •

edited

Loading