fix for preview copied status file and filename with {} #357
Merged
idursun merged 3 commits intoidursun:mainfrom Oct 27, 2025
Merged
fix for preview copied status file and filename with {} #357idursun merged 3 commits intoidursun:mainfrom
idursun merged 3 commits intoidursun:mainfrom
Conversation
Collaborator
Author
|
hey @idursun just saw your comments about how to recreate the bug in #355, this is what i have: echo "copy1\ncopy2\ncopy3\n" > copy-source
jj new
# modify the source slightly and create a copy with similar content
echo "copy1\ncopy2\ncopy3\nsource\n" > copy-source
echo "copy1\ncopy2\ncopy3\ntarget\n" > copy-target
jj status
# show `C` prefix
jjui
# doesn't show `C` |
Owner
|
@baggiiiie FYI, you can add "fixes #issuenumber" in your PR description so that the issue is automatically closed when PR is merged. |
Collaborator
Author
@idursun hey thank you for the encouraging words! love to contribute when i could! and thanks for letting me know about |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 24, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [idursun/jjui](https://github.com/idursun/jjui) | patch | `v0.9.5` -> `v0.9.6` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>idursun/jjui (idursun/jjui)</summary> ### [`v0.9.6`](https://github.com/idursun/jjui/releases/tag/v0.9.6) [Compare Source](idursun/jjui@v0.9.5...v0.9.6) Another community driven release, mostly focusing on every day improvements. #### What's Changed - fix(ace\_jump): close operation after applying jump by [@​baggiiiie](https://github.com/baggiiiie) in [#​351](idursun/jjui#351) - feat: auto-detect preview placement, on by default by [@​lbonn](https://github.com/lbonn) in [#​348](idursun/jjui#348) - feat: allow remote selection in git menu by [@​baggiiiie](https://github.com/baggiiiie) in [#​349](idursun/jjui#349) - fix(fuzzy\_files): quote path for editor command by [@​baggiiiie](https://github.com/baggiiiie) in [#​354](idursun/jjui#354) - fix for preview copied status file and filename with {} by [@​baggiiiie](https://github.com/baggiiiie) in [#​357](idursun/jjui#357) - Support interactive file-level restores by [@​remo5000](https://github.com/remo5000) in [#​365](idursun/jjui#365) - fuzzy\_files: remove quoting for files in revset by [@​baggiiiie](https://github.com/baggiiiie) in [#​370](idursun/jjui#370) - ui/git: add --tracked to git fetch by [@​baggiiiie](https://github.com/baggiiiie) in [#​368](idursun/jjui#368) - operation: add ForceApply to squash/rebase footer by [@​baggiiiie](https://github.com/baggiiiie) in [#​371](idursun/jjui#371) - abandon: add force apply to footer help menu by [@​baggiiiie](https://github.com/baggiiiie) in [#​373](idursun/jjui#373) - docs(README): add winget and scoop as installation method in Windows by [@​abgox](https://github.com/abgox) in [#​362](idursun/jjui#362) - fix(set\_parents): keep parent order by [@​idursun](https://github.com/idursun) in [#​375](idursun/jjui#375) - fix(light theme): Removed the default border style of `bright white` as it was overriding the `text` style which should be the terminal’s default foreground and background. #### New Contributors - [@​lbonn](https://github.com/lbonn) made their first contribution in [#​348](idursun/jjui#348) - [@​remo5000](https://github.com/remo5000) made their first contribution in [#​365](idursun/jjui#365) - [@​abgox](https://github.com/abgox) made their first contribution in [#​362](idursun/jjui#362) **Full Changelog**: <idursun/jjui@v0.9.5...v0.9.6> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xOS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Fix preview for files with
Ccopied status and detail view with filenames with{}for
Ccopied file preview, see #355.cause
Ccopied status file preview:C, jjui runs command similar tojj diff --color always -r kq 'file:"{new_file.md => copied_file.md}"'Cstatus isn't registeredjjto fail withWarning: No matching entries for paths: {new_file.md => copied_file.md}filename with
{}:C(copied) andR(renamed) contain{}, and here usesstrings.Containsandstrings.Indexto match{}, it causes panic and index out of bound error when filename contains{}fix
Cstatus and relevant changes{}iotaenum for filestatusafter fix
what
jjshows:what
jjuishows: