Add 'instance UniformRange Natural'#126
Merged
curiousleo merged 1 commit intoidontgetoutmuch:interface-to-performancefrom May 11, 2020
Merged
Add 'instance UniformRange Natural'#126curiousleo merged 1 commit intoidontgetoutmuch:interface-to-performancefrom
curiousleo merged 1 commit intoidontgetoutmuch:interface-to-performancefrom
Conversation
dba6aa8 to
bda3a67
Compare
curiousleo
added a commit
that referenced
this pull request
May 13, 2020
curiousleo
added a commit
that referenced
this pull request
May 13, 2020
lehins
pushed a commit
that referenced
this pull request
May 18, 2020
curiousleo
added a commit
that referenced
this pull request
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main addition here is to add
instance UniformRange Natural, also see haskell#44.To do this, I changed the
Integer-specificuniformIntegerMto a genericuniformIntegralM. Since this function was and is recursive, I changed the pragma fromINLINEtoINLINEABLE.I made sure that these more generic functions are no slower than before. Note that
random/Integerbenchmarks small ranges, for which a fast path is triggered;uniformR/unbounded/Integerand the newuniformR/unbounded/Naturalbenchmark very large ranges where there is no fast path.Before (9ee79a7):
After (this PR):
Other changes:
uniformRinstead ofrandomR; this allow us to make the constraints more preciseNaturalbenchmark and specs