Slight improvement in performance. #125
Merged
idontgetoutmuch merged 4 commits intointerface-to-performancefrom May 13, 2020
Merged
Slight improvement in performance. #125idontgetoutmuch merged 4 commits intointerface-to-performancefrom
idontgetoutmuch merged 4 commits intointerface-to-performancefrom
Conversation
curiousleo
approved these changes
May 8, 2020
Collaborator
curiousleo
left a comment
There was a problem hiding this comment.
LGTM. This made me realise that we currently have neither tests nor benchmarks for the bytestring generators in the repo. If this was a benchmark-driven optimisation, it would obviously be nice if we could include that benchmark in the benchmark suite.
e554cbe to
5c4fe6c
Compare
Collaborator
Author
|
I thought someone might ask about that. This PR also adds couple of tests and a benchmark for Also adds |
1 task
idontgetoutmuch
approved these changes
May 13, 2020
910a8f1 to
c33814e
Compare
idontgetoutmuch
added a commit
that referenced
this pull request
May 13, 2020
* Slight improvement in performance. (for small lengths it doubles the performance) * Addition of a couple tests for ByteString generation * Add `Eq` and `NFData` instances for `StdGen` * Add benchmark for generation of `ShortByteString`s
lehins
added a commit
that referenced
this pull request
May 18, 2020
* Slight improvement in performance. (for small lengths it doubles the performance) * Addition of a couple tests for ByteString generation * Add `Eq` and `NFData` instances for `StdGen` * Add benchmark for generation of `ShortByteString`s
curiousleo
pushed a commit
that referenced
this pull request
May 19, 2020
* Slight improvement in performance. (for small lengths it doubles the performance) * Addition of a couple tests for ByteString generation * Add `Eq` and `NFData` instances for `StdGen` * Add benchmark for generation of `ShortByteString`s
curiousleo
pushed a commit
that referenced
this pull request
May 20, 2020
* Slight improvement in performance. (for small lengths it doubles the performance) * Addition of a couple tests for ByteString generation * Add `Eq` and `NFData` instances for `StdGen` * Add benchmark for generation of `ShortByteString`s
Shimuuar
pushed a commit
to Shimuuar/random
that referenced
this pull request
Jan 6, 2025
Support mtl-2.3-rc3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance of generation of
ShortByteString(for small lengths it doubles the performance)