Ready for review#124
Conversation
curiousleo
left a comment
There was a problem hiding this comment.
Thank you for doing this! I find claims of performance improvements much more credible when a lower bound is given too. In this case the lower bound is really respectable, so let's include it!
CHANGELOG.md
Outdated
| 3. Monadic adapters for pure generators (providing a uniform monadic | ||
| interface to pure and monadic generators). | ||
| 4. Faster by more x10 (depending on the type) - see below for benchmarks. | ||
| 4. Faster by more x1000 (depending on the type) - see below for benchmarks. |
There was a problem hiding this comment.
Super-nit: I tend to be skeptical of claims like "better by up to ". In this case, even the least improved generator is impressive, so I think we should mention it. i.e. "40 to 1000 times faster pseudo-random value generation". (I think 40 is about right, but worth checking again).
There was a problem hiding this comment.
Well the minimum is INTEGER which is only 13% faster - the next lowest is x18 for types with 8 bits - I think if this is too heavily caveated you lose the message
There was a problem hiding this comment.
Fair enough. No need to dwell on this too much. The other alternative that comes to mind would be e.g. "Faster generation for all implemented types, by up to x1000 for fixed-width integral types".
But if you think that's too much caveating, I'm fine with keeping this as it is.
There was a problem hiding this comment.
Maybe something vague, but still accurate with a lower bound, along the lines: "Performance improvements all across the board with generation of most types being faster on the orders of x100 to x1000"
CHANGELOG.md
Outdated
| Here are some benchmarks run on a 3.1 GHz Intel Core i7. The full | ||
| benchmarks can be run using e.g. `stack bench`. The benchmarks are | ||
| measured in milliseconds per 100,000 generations. In some cases, the | ||
| performance is over x1000 times better. |
There was a problem hiding this comment.
Same here - I give much more weight to such claims personally when a lower bound is also given.
CHANGELOG.md
Outdated
| 3. Monadic adapters for pure generators (providing a uniform monadic | ||
| interface to pure and monadic generators). | ||
| 4. Faster by more x1000 (depending on the type) - see below for benchmarks. | ||
| 4. Faster in all cases bar one by more than x18 (N.B. x18 not 18%) and |
There was a problem hiding this comment.
What does this mean: bar one by? Was that intended or am I missing a piece of English vocabulary?
There was a problem hiding this comment.
bar means except probably more common in the North - the exception is Integer - I will replace bar by except
There's a famous song: On Ilkley Moor bar t'hat (on Ilkley Moor without a hat) - actually it's probably not that famous - my children wouldn't know it.
|
Looking at the whole file, I just noticed this: I've seen a bunch of projects adding new releases to the top of the changelog rather than at the bottom. I guess this way the most recent = relevant changes are visible immediately. The most recent previous release, 1.1, is at the top. In the interest of consistency, I suggest moving the 1.2 release notes to the beginning of the file. |
Excellent idea! |
5a84623 to
6969cbb
Compare
No description provided.