Skip to content

Cleanup#120

Merged
lehins merged 4 commits intointerface-to-performancefrom
cleanup
May 6, 2020
Merged

Cleanup#120
lehins merged 4 commits intointerface-to-performancefrom
cleanup

Conversation

@lehins
Copy link
Copy Markdown
Collaborator

@lehins lehins commented May 5, 2020

Cmm stuff was removed, so there is no longer need for .ghci file and -fobject-code flag in doctests

Also compilation warnings and horrendous formatting of legacy benchmarks was bugging me, so it is now fixed. Redundant CPP was also removed, since those cabal flags are long gone. There are no semantic changes to benchmarks, so they will all work exactly as before.

lehins added 2 commits May 5, 2020 20:08
@lehins
Minor cleanups:
0058d77 
* Remove -fobject-code compilation, since Cmm was removed
* Fix example in cabal file
* Take care of some compile warnings in legacy benchmarks
@lehins
Lagacy benchmarks code formatting and cleanup. Get rid of compilation…
f1cbbb7 
… warnigns
@curiousleo
Copy link
Copy Markdown
Collaborator

curiousleo commented May 6, 2020 •
edited
Loading

LGTM! I'm generally very much in favour of consistent formatting, ideally using an auto-formatter (like we're already using cabal format for random.cabal). I would be happy to adopt one for all code in this project.

I'm actually not very fussed about the style that is enforced, I just like it to be consistent. I've used ormolu in the past, which has the advantage of not being configurable at all. But hindent or something else would absolutely do the trick too.

WDYT?

curiousleo
curiousleo approved these changes May 6, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@curiousleo curiousleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lehins!

@lehins
Copy link
Copy Markdown
Collaborator Author

lehins commented May 6, 2020

@curiousleo hident is what I use, one of those days I'll give ormolu a try. I don't think we need to dwell to much on the formatting and trying to be 100% consistent throughout the codebase is not a good idea either in my opinion. Sometimes it is good to format it manually to improve the clarity of some complicated bit of code.

I did reformat cause there were tabs symbols and formatting was just horrendous.

@lehins lehins merged commit a091bfc into interface-to-performance May 6, 2020
curiousleo pushed a commit that referenced this pull request May 19, 2020
@lehins @curiousleo
Merge pull request #120 from idontgetoutmuch/cleanup
5182c58 
Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curiousleo curiousleo curiousleo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lehins @curiousleo