Make global StdGen to work in MonadIO#119
Merged
idontgetoutmuch merged 1 commit intointerface-to-performancefrom May 5, 2020
Merged
Make global StdGen to work in MonadIO#119idontgetoutmuch merged 1 commit intointerface-to-performancefrom
idontgetoutmuch merged 1 commit intointerface-to-performancefrom
Conversation
curiousleo
reviewed
May 5, 2020
Collaborator
curiousleo
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM.
curiousleo
approved these changes
May 5, 2020
Collaborator
curiousleo
left a comment
There was a problem hiding this comment.
Will this break Random instances that define randomIO or randomRIO?
Even if the answer is "yes" in theory, I doubt there are many of them in practice, so I'm in favour of this change.
curiousleo
pushed a commit
that referenced
this pull request
May 19, 2020
Make global StdGen to work in MonadIO
Shimuuar
pushed a commit
to Shimuuar/random
that referenced
this pull request
Jan 6, 2025
…-haddock Improve documentation of the global StdGen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
IOmake all global stdgen functions:getStdRandomgetStdGensetStdGennewStdGenwork in
MonadIOAlso, instead of deprecating, move
randomIO,randomRIOoutsideRandomclass. I can't even understand the reasoning why they where part of theRandomclass to begin with.