Move build system from poetry to hatch#354
Merged
C4ptainCrunch merged 3 commits intomainfrom Jul 19, 2022
Merged
Conversation
- project and dependency declaration is now according to the standard - optional-dependencies are declared nicely (including pinned tox versions for flake8 and mypy) - upper version caps preferred by poetry have been removed - removed lock file which we don't need
C4ptainCrunch
approved these changes
Jul 11, 2022
Member
C4ptainCrunch
left a comment
There was a problem hiding this comment.
I have a hard time following all the new packaging developments in Python right now (i already did not grasp poetry fully) so i trust you on this. Thank you for taking the time to modernise our setup 🚀
(Small detail before merging, don't forget to update the contributing docs ;) )
Contributor
See #357, does that fit the bill? |
Co-authored-by: 0xC4 <nikita.marchant@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that hatch is about to be PyPA's successor to setuptools and in my experience with other projects it's so much nicer to use (and esp. less-opinionated) than Poetry, so here's a PR for moving to it. The pyproject.toml file now looks a lot cleaner and also follows the corresponding PEPs more closely. You shouldn'y actually notice this change much (except if you are directly invoking
poetry) aspip install,python -m build,tox,... nicely abstract across the build backend and automatically use the correct one.Also fixes #352.