Merged
Conversation
C4ptainCrunch
requested changes
Jul 18, 2022
Member
C4ptainCrunch
left a comment
There was a problem hiding this comment.
Thanks ! If we address the few remarks, this seems good enough to be merged in the hatch branch and in turn merge it too ! 🥳
Co-authored-by: 0xC4 <nikita.marchant@gmail.com>
publishing to pypi is covered by github action
This reverts commit da9af66.
C4ptainCrunch
approved these changes
Jul 19, 2022
Member
|
Thank you @strobeflash 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote the contribution docs to match the new release workflow and tooling.
Could not test the actual release process but hopefully close enough.