Skip to content

ci(promote): add force_skip_soak input to break the soak deadlock#443

Merged
icebear0828 merged 1 commit intodevfrom
promote-force-skip-soak
May 5, 2026
Merged

ci(promote): add force_skip_soak input to break the soak deadlock#443
icebear0828 merged 1 commit intodevfrom
promote-force-skip-soak

Conversation

@icebear0828
Copy link
Copy Markdown
Owner

Summary

Test plan

  • js-yaml parses the workflow file; workflow_dispatch.inputs.force_skip_soak registered correctly.
  • Functional verification: after this PR merges, run gh workflow run promote-dev-to-master.yml --ref dev -f force_skip_soak=true and confirm soak step prints Soak skipped via workflow_dispatch input and master fast-forwards.

Notes

  • Behavior unchanged for the scheduled cron (inputs.force_skip_soak is empty for non-dispatch triggers, evaluates to not-true).
  • This is a pure CI change; no application code touched.

The soak check measures `now - dev_HEAD_timestamp >= 24h`, which means
every new merge into dev resets the clock. Under any non-trivial merge
cadence, dev never satisfies the soak gate and master stagnates: PRs
#437/#438/#439/#440/#442 all stacked on dev for a week with no
promotion.

Add a `force_skip_soak` boolean input to workflow_dispatch (default
false). Schedule cron remains untouched and continues to enforce the
24h rule. Only manual triggers can bypass, and only when the operator
explicitly sets the input to true — intended for sync-back / merge
commits whose content has actually been on dev long enough but whose
HEAD timestamp is misleadingly fresh.

Test plan: yaml syntax verified via js-yaml. Functional verification
will be the next manual workflow_dispatch run with the input set.
@icebear0828 icebear0828 merged commit 774142b into dev May 5, 2026
@icebear0828 icebear0828 deleted the promote-force-skip-soak branch May 5, 2026 08:03
icebear0828 added a commit that referenced this pull request May 5, 2026
The soak check measures `now - dev_HEAD_timestamp >= 24h`, which means
every new merge into dev resets the clock. Under any non-trivial merge
cadence, dev never satisfies the soak gate and master stagnates: PRs
#437/#438/#439/#440/#442 all stacked on dev for a week with no
promotion.

Add a `force_skip_soak` boolean input to workflow_dispatch (default
false). Schedule cron remains untouched and continues to enforce the
24h rule. Only manual triggers can bypass, and only when the operator
explicitly sets the input to true — intended for sync-back / merge
commits whose content has actually been on dev long enough but whose
HEAD timestamp is misleadingly fresh.

Test plan: yaml syntax verified via js-yaml. Functional verification
will be the next manual workflow_dispatch run with the input set.

Co-authored-by: icebear0828 <icebear0828@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant