feat: implicit resume via effectiveConversationId for chat/gemini routes#432
Merged
icebear0828 merged 2 commits intodevfrom May 2, 2026
Merged
feat: implicit resume via effectiveConversationId for chat/gemini routes#432icebear0828 merged 2 commits intodevfrom
icebear0828 merged 2 commits intodevfrom
Conversation
- proxy-handler.ts: introduce effectiveConversationId fallback chain (clientConversationId → derivedConversationId → promptCacheKey) for both chainConversationId and implicitPrevRespId lookup - chat.ts: forward req.user as clientConversationId - gemini.ts: extract x-conversation-id/x-session-id as clientConversationId - Add implicit-resume-from-derived-key.test.ts
icebear0828
added a commit
that referenced
this pull request
May 5, 2026
…tes (#432) * feat: implicit resume via effectiveConversationId for chat/gemini routes - proxy-handler.ts: introduce effectiveConversationId fallback chain (clientConversationId → derivedConversationId → promptCacheKey) for both chainConversationId and implicitPrevRespId lookup - chat.ts: forward req.user as clientConversationId - gemini.ts: extract x-conversation-id/x-session-id as clientConversationId - Add implicit-resume-from-derived-key.test.ts * fix: resolve empty string collision and missing ProxyRequest imports --------- Co-authored-by: icebear0828 <icebear0828@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectiveConversationIdfallback chain (clientConversationId→derivedConversationId→promptCacheKey) inproxy-handler.ts.effectiveConversationIdfor bothchainConversationIdand theimplicitPrevRespIdlookup condition to ensure seamless implicit resume even without explicit client-provided session IDs.req.userfrom the OpenAI schema asclientConversationIdinchat.ts.x-conversation-idandx-session-idheaders asclientConversationIdingemini.ts.implicit-resume-from-derived-key.test.tsto validate multi-turn session affinity logic.Test plan
npx vitest run tests/unit/routes/implicit-resume-from-derived-key.test.ts(all 4 tests pass)npx vitest run(1649 tests pass)