Skip to content

Fix field-based storage test#2

Merged
iNikem merged 1 commit into
iNikem:storage-perffrom
trask:iNikem-storage-perf
Jul 23, 2020
Merged

Fix field-based storage test#2
iNikem merged 1 commit into
iNikem:storage-perffrom
trask:iNikem-storage-perf

Conversation

@trask

@trask trask commented Jul 23, 2020 •
edited
Loading

Copy link
Copy Markdown

The issue was that StorageKey, which was being used as the InstrumentationContext key, was part of the instrumentation itself, and so it wasn't being instrumented itself, and so the field was not being added to it, and so InstrumentationContext was falling back to a map.

New numbers:

Benchmark                                                     Mode  Cnt     Score     Error   Units
StorageBenchmark.contextStorage                               avgt   20    26.768 ±   0.331   ns/op
StorageBenchmark.contextStorage:·gc.alloc.rate                avgt   20  2089.803 ±  25.111  MB/sec
StorageBenchmark.contextStorage:·gc.alloc.rate.norm           avgt   20    88.000 ±   0.001    B/op
StorageBenchmark.fieldStorage                                 avgt   20     3.174 ±   0.045   ns/op
StorageBenchmark.fieldStorage:·gc.alloc.rate                  avgt   20     0.004 ±   0.001  MB/sec
StorageBenchmark.fieldStorage:·gc.alloc.rate.norm             avgt   20    ? 10??              B/op
StorageBenchmark.noStorage                                    avgt   20     3.838 ±   0.075   ns/op
StorageBenchmark.noStorage:·gc.alloc.rate                     avgt   20     0.004 ±   0.001  MB/sec
StorageBenchmark.noStorage:·gc.alloc.rate.norm                avgt   20    ? 10??              B/op

@trask trask requested a review from iNikem as a code owner July 23, 2020 02:03
@trask trask mentioned this pull request Jul 23, 2020
Closed
@iNikem iNikem merged commit f0209bc into iNikem:storage-perf Jul 23, 2020
@trask trask deleted the iNikem-storage-perf branch August 4, 2020 22:56
iNikem pushed a commit that referenced this pull request Nov 3, 2020
@kuba-wu
apache camel 2.20.x instrumentation (open-telemetry#1397)
049358e 
* apache camel 2.20.x instrumentation

* removed instrumentation advice from helper classes

* code review #1

* code review #2 / experimental server name update

* code review changes / new tests, improved direct, new license header

* rebase changes

* code review changes

* code review changes, REST tests added

* changes after rebase to newest master

* code review changes

* code review

* code review

* rebase to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iNikem iNikem iNikem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trask @iNikem