HDR Support#112
Merged
Merged
Conversation
vaxerski
reviewed
Dec 5, 2024
vaxerski
left a comment
Member
There was a problem hiding this comment.
Nice work. Obviously after fixing the problems we first need a Hyprland MR.
For the colorimetry utils and stuff, I think hyprgraphics would be a better place, though atm I am unsure what you want to put there.
3 tasks
Member
|
tag me for review when this one is ready to go |
Contributor
Author
|
Should be ready. |
vaxerski
reviewed
Jan 3, 2025
Member
|
apart from the one unresolved conversation lgtm |
vaxerski
approved these changes
Jan 5, 2025
UjinT34
added a commit
to UjinT34/aquamarine
that referenced
this pull request
Jan 9, 2025
vaxerski
added a commit
that referenced
this pull request
Jan 10, 2025
* do not set cursor planeProps unless smth changed * do not skip cursor state flag setting * drm: scan only cards and not outputs, safeguard against null renderer (#106) * drm: dont scan card outputs no need to scan for card[0-9]* and probe card0-eDP etc if they are kms, bootvga and rendernodes etc. skip the wildcard and remove a unused size_t variable. * drm: dont commit state if renderer is missing setting certain env vars to force egl implentations makes the render creation fail on the second gpu. instead of causing a coredump, safeguard commitState and let the monitor turn blank instead. * props: bump version to 0.5.0 * drm: Validate conn before dereference in CDRMAtomicRequest::commit() (#108) During startup, CDRMAtomicImpl::reset() may emit a call to method commit of a CDRMAtomicRequest instance with member "conn" uninitialized, leading to a segfault. Validate the the pointer before dereference it as a workaround. Fixes: 55ac962 ("DRM: preliminary atomic support") Closes: #107 Signed-off-by: Yao Zi <ziyao@disroot.org> * buffer: remove useless forward def * drm: clearer flow when rescanning connectors (#113) * consolidates into checkOutput for clearer flow when rescanning connectors * add error log * drm: allow multigpu blit from explicit to implicit (#114) * version: bump to 0.5.1 * flake.lock: update * flake.nix: gcc13 -> gcc14 (#118) * drm: udev scan only drm_minor, not connectors (#119) * drm: log errno set by drmModeAtomicCommit (#120) * drm: moved null check for renderer to shouldBlit() (#109) (#121) * drm: only fail INVALID format when enabled (#122) * flake.lock: update * drm: only clear buffers when fullReconfigure succeeds (#124) * core/drm: Add HDR Support (#112) * version: bump to 0.6.0 * drm: limit udev drm_minor to Linux after a132fa4 (#129) Not implemented by libudev-devd yet: [ERR] [AQ] drm: No gpus in scanGPUs. [ERR] [AQ] drm: Found no gpus to use, cannot continue [ERR] [AQ] DRM Backend failed * do not set cursor planeProps unless smth changed * test separate cursor commits * do not change hdr blob unless asked to * rebase * split atomic commit processing and move hdr & colorspace into modeset * fix wide color gamut flag & cleanup * remove unused debug var --------- Signed-off-by: Yao Zi <ziyao@disroot.org> Co-authored-by: Tom Englund <tomenglund26@gmail.com> Co-authored-by: Vaxry <vaxry@vaxry.net> Co-authored-by: Ziyao <ziyao@disroot.org> Co-authored-by: Ikalco <73481042+ikalco@users.noreply.github.com> Co-authored-by: Mihai Fufezan <mihai@fufexan.net> Co-authored-by: Austin Horstman <khaneliman12@gmail.com> Co-authored-by: Richard Henninger <56615615+richen604@users.noreply.github.com> Co-authored-by: Jan Beich <jbeich@FreeBSD.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses drm properties and enums needed for HDR.
Parses edid info needed for HDR and exposes it to HL.
output->state->setWideColorGamutto change colorspace toBT2020_RGB.output->state->setHDRMetadatato set HDR properties.Needs HL changes to be useful. Probably needs some extra colorimetry helpers in hyprutils and some helpers to create hdr metadata. kwin seems to rely only on edid info to create this metadata. wlroots https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4594 passes almost all parameters with a separate struct.
Also adds support for https://drmdb.emersion.fr/properties/3435973836/DEGAMMA_LUT just in case