Simplify and fix hdr metadata setting#9706
Conversation
|
@UjinT34, sorry I use this PR to ask this question, as it's related to It's written that it's a boolean set by default to |
|
Looks like site is outdated https://github.com/hyprwm/hyprland-wiki/blob/main/pages/Configuring/Variables.md |
|
Perfect, thanks so much for the explanations! Sorry I missed it, I didn't notice that the wiki set on git was outdated. I'm creating an issue for hyprland-wiki. |
* simplify and fix hdr metadata setting * keep incorrect(?) cm skip till hyprwm#9600
* simplify and fix hdr metadata setting * keep incorrect(?) cm skip till #9600
* simplify and fix hdr metadata setting * keep incorrect(?) cm skip till hyprwm#9600
Describe your PR, what does it fix/add?
Fixes unwanted switch to SDR for fullscreen apps with CM support when
cm_fs_passthrough=2(foot should no longer cause a modeset)Fixes metadata creation. Primaries weren't sent correctly. Doesn't seem to have any effect on nvidia, other drivers might have some color improvements (need some info on how those values should be handled by the driver)
Sends primaries and luminances info for SDR content in case it'll be useful for fixing SDR passthrough on AQ side. Might make sense to set a hdr metadata blob with SDR eotf if those primaries and luminances are handled by the driver.
Simplifies hdr metadata switching logic
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
CM skip for rendering without a surface data should be removed. E verything that doesn't explicitly set an image description is considered sRGB and should go through the CM if monitor isn't in sRGB. If there are cases when
renderTextureInternalWithDamageis called without a surface and the provided texture is encoded the same way then there should be a way to provide this info explicitly. Image description should be set on aCTexturelevel probably. Keeping it as is till #9600Is it ready for merging, or does it need work?
Ready