Fix CM for DS and SDR passthrough#11503
Conversation
With this PR, PQ games work without DS (blocked by color management) and scRGB games don't work at all (completely wrong colors not just oversaturated) AMD GPU. |
|
Retested after new set of commits
Tested with all |
|
Something is wrong during initial start. Switching workspaces should help with oversaturated scRGB. I am looking into it. |
|
Fixed |
|
Tested Control. It works fine. Cyberpunk is a bit more iffy. Switching between HDR modes and/or SDR, sometimes doesn't trigger AutoHDR properly and you need a workspace toggle to fix it. It's the only game I know/own that has multiple HDR options so it's not easy to test it in a different game. Without this PR, Control is very hit or miss and Cyberpunk is even worse. |
I've tested it with Cyberpunk and mangohud. The game itself shouldn't show any noticeable difference between PQ and scRGB. Mangohud has washed out (correct?) colors with scRGB and oversaturated with PQ. Works the same with different DS and passthrough combos. |
Can't reproduce anymore, everything works fine |
Describe your PR, what does it fix/add?
Fixes SDR primaries conversion for DS and
cm_fs_passthrough = 1. Blocks DS when CM without shader isn't supported.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Replaces CTM provided by ctm proto in fullscreen when necessary.
Is it ready for merging, or does it need work?
Ready