Skip to content

Fix CM for DS and SDR passthrough#11503

Merged
vaxerski merged 8 commits into
hyprwm:mainfrom
UjinT34:drm-cm-ds
Aug 29, 2025
Merged

Fix CM for DS and SDR passthrough#11503
vaxerski merged 8 commits into
hyprwm:mainfrom
UjinT34:drm-cm-ds

Conversation

@UjinT34

@UjinT34 UjinT34 commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Describe your PR, what does it fix/add?

Fixes SDR primaries conversion for DS and cm_fs_passthrough = 1 . Blocks DS when CM without shader isn't supported.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Replaces CTM provided by ctm proto in fullscreen when necessary.

Is it ready for merging, or does it need work?

Ready

@LionHeartP

Copy link
Copy Markdown
Contributor

With this PR, PQ games work without DS (blocked by color management) and scRGB games don't work at all (completely wrong colors not just oversaturated)

AMD GPU.

@LionHeartP

Copy link
Copy Markdown
Contributor

Retested after new set of commits

  • HDR PQ works with DS now
  • scRGB successfully blocks DS, but colors are oversaturated now

Tested with all cm_fs_passthrough settings.

@UjinT34

UjinT34 commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

Something is wrong during initial start. Switching workspaces should help with oversaturated scRGB. I am looking into it.

@UjinT34

UjinT34 commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

Fixed

@LionHeartP

LionHeartP commented Aug 24, 2025

Copy link
Copy Markdown
Contributor

Tested Control. It works fine.

Cyberpunk is a bit more iffy. Switching between HDR modes and/or SDR, sometimes doesn't trigger AutoHDR properly and you need a workspace toggle to fix it. It's the only game I know/own that has multiple HDR options so it's not easy to test it in a different game.

Without this PR, Control is very hit or miss and Cyberpunk is even worse.

@UjinT34

UjinT34 commented Aug 24, 2025

Copy link
Copy Markdown
Contributor Author

Cyberpunk is a bit more iffy. Switching between HDR modes and/or SDR, sometimes doesn't trigger AutoHDR properly and you need a workspace toggle to fix it. It's the only game I know/own that has multiple HDR options so it's not easy to test it in a different game.

I've tested it with Cyberpunk and mangohud. The game itself shouldn't show any noticeable difference between PQ and scRGB. Mangohud has washed out (correct?) colors with scRGB and oversaturated with PQ. Works the same with different DS and passthrough combos.
Any reliable way to reproduce? And some logs would be nice.

@LionHeartP

Copy link
Copy Markdown
Contributor

I've tested it with Cyberpunk and mangohud. The game itself shouldn't show any noticeable difference between PQ and scRGB. Mangohud has washed out (correct?) colors with scRGB and oversaturated with PQ. Works the same with different DS and passthrough combos. Any reliable way to reproduce? And some logs would be nice.

Can't reproduce anymore, everything works fine

Comment thread src/render/Renderer.cpp
@vaxerski vaxerski merged commit 05a1c0a into hyprwm:main Aug 29, 2025
13 checks passed
Levizor pushed a commit to Levizor/Hyprland that referenced this pull request Sep 8, 2025
Boom-Hacker pushed a commit to Boom-Hacker/Hyprland that referenced this pull request Sep 27, 2025
Boom-Hacker pushed a commit to Boom-Hacker/Hyprland that referenced this pull request Sep 27, 2025
Boom-Hacker pushed a commit to Boom-Hacker/Hyprland that referenced this pull request Sep 28, 2025
crthpl pushed a commit to crthpl/Hyprland that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants