Fix failing test due to changes in dask.keys keyword#2888
Merged
ericpre merged 1 commit intohyperspy:RELEASE_next_patchfrom Feb 17, 2022
Merged
Fix failing test due to changes in dask.keys keyword#2888ericpre merged 1 commit intohyperspy:RELEASE_next_patchfrom
ericpre merged 1 commit intohyperspy:RELEASE_next_patchfrom
Conversation
This is due to a change from dask-2022.1.1.
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2888 +/- ##
======================================================
- Coverage 77.62% 77.61% -0.02%
======================================================
Files 202 202
Lines 30113 30113
Branches 6776 6776
======================================================
- Hits 23375 23371 -4
- Misses 4996 5002 +6
+ Partials 1742 1740 -2
Continue to review full report at Codecov.
|
ericpre
approved these changes
Feb 17, 2022
Member
ericpre
left a comment
There was a problem hiding this comment.
For future reference, it seems to be coming from dask/dask#7417.
It is not great to rely on the name of dask keys but this is another story!
magnunor
added a commit
to magnunor/hyperspy
that referenced
this pull request
Feb 18, 2022
This is due to a change which was introduced in dask-2022.1.1. Seems to be coming from: dask/dask#7417 Related pull request: hyperspy#2888
ericpre
pushed a commit
to ericpre/rosettasciio
that referenced
this pull request
Jul 23, 2022
This is due to a change which was introduced in dask-2022.1.1. Seems to be coming from: dask/dask#7417 Related pull request: hyperspy/hyperspy#2888
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a test in RELEASE_next_minor is failing:
FAILED hyperspy/tests/io/test_hdf5.py::test_saving_close_file.This is due to this code:
Since
dask-2022.1.1this key starts withoriginal-array, while indask-2022.1.0(and earlier),array-original.There has been some changes in
RELEASE_next_minor, compared toRELEASE_next_patch. InRNp, this functionality is inclose_file(https://github.com/hyperspy/hyperspy/blob/RELEASE_next_patch/hyperspy/_signals/lazy.py#L171)In
RNm, this is in_get_file_handle(https://github.com/hyperspy/hyperspy/blob/RELEASE_next_minor/hyperspy/_signals/lazy.py#L323)Thus, this pull request fixes the issue in RNp, which should be easy to "move" to RNm.