feat!: Finalize non-empty blocks by allowing empty blocks after them#5320
Merged
dima74 merged 4 commits intohyperledger-iroha:mainfrom Mar 7, 2025
Merged
Conversation
s8sato
reviewed
Feb 20, 2025
mversic
reviewed
Feb 24, 2025
mversic
approved these changes
Feb 24, 2025
mversic
previously approved these changes
Feb 24, 2025
844348c to
121a676
Compare
s8sato
reviewed
Feb 26, 2025
s8sato
reviewed
Feb 26, 2025
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
121a676 to
6fb1996
Compare
mversic
previously approved these changes
Mar 6, 2025
s8sato
previously approved these changes
Mar 7, 2025
Contributor
|
Could you add a commit to |
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic
approved these changes
Mar 7, 2025
s8sato
approved these changes
Mar 7, 2025
dima74
added a commit
to dima74/iroha
that referenced
this pull request
Mar 7, 2025
…yperledger-iroha#5320) Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
dima74
added a commit
to dima74/iroha
that referenced
this pull request
Mar 7, 2025
…yperledger-iroha#5320) Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
s8sato
pushed a commit
that referenced
this pull request
Mar 7, 2025
…fter them (#5344) * feat!: Finalize non-empty blocks by allowing empty blocks after them (#5320) Signed-off-by: Dmitry Murzin <diralik@yandex.ru> * chore: update CHANGELOG.md Signed-off-by: Dmitry Murzin <diralik@yandex.ru> * chore: minor version bump to `2.0.0-rc.1.3` Signed-off-by: Dmitry Murzin <diralik@yandex.ru> --------- Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
s8sato
pushed a commit
that referenced
this pull request
Mar 7, 2025
… blocks after them (#5345) * feat!: Finalize non-empty blocks by allowing empty blocks after them (#5320) Signed-off-by: Dmitry Murzin <diralik@yandex.ru> * chore: update CHANGELOG.md Signed-off-by: Dmitry Murzin <diralik@yandex.ru> * chore: minor version bump to `2.0.0-rc.1.3` Signed-off-by: Dmitry Murzin <diralik@yandex.ru> --------- Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
0x009922
reviewed
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5317
Solution
If there are no transactions after a timeout period, and the previous block has transactions, then an empty block will be created. Note that there can't be two sequential empty blocks.
Migration Guide
An empty block will be added after a non-empty one if there are no transactions, therefore e.g. pre-commit trigger might get executed more times than you expected.
Also note about
/statusendpoint response fields:blocks- existing field (no change), note that it will include empty blocksblocks_non_empty- new field, count of non-empty blocksChecklist
CONTRIBUTING.md.