refactor: sign only block's header, not the whole payload#5000
Merged
nxsaken merged 1 commit intohyperledger-iroha:mainfrom Aug 26, 2024
Merged
refactor: sign only block's header, not the whole payload#5000nxsaken merged 1 commit intohyperledger-iroha:mainfrom
nxsaken merged 1 commit intohyperledger-iroha:mainfrom
Conversation
30353b4 to
6525aba
Compare
dd9abdc to
0332429
Compare
s8sato
approved these changes
Aug 23, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
0332429 to
782565c
Compare
mversic
added a commit
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
it's not necessary to sign the whole block payload since block header holds the merkle tree root hash
Reason
this will enable us to work on #4914