fix(torii): use GET for blocks stream#4990
Merged
nxsaken merged 1 commit intohyperledger-iroha:mainfrom Aug 21, 2024
Merged
Conversation
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Mingela
approved these changes
Aug 21, 2024
mversic
approved these changes
Aug 21, 2024
mversic
pushed a commit
that referenced
this pull request
Aug 30, 2024
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Blocks stream endpoint doesn't work with standard WebSocket clients because it uses
POST. The standard says it should beGET: https://stackoverflow.com/questions/50386211/should-websocket-server-only-handle-get-requestsSolution
Use
GETfor blocks stream route.Events stream already uses
GET(discrepancy btw).Checklist
CONTRIBUTING.md.