Skip to content

fix: add missing mathematical operations to Numeric#4976

Merged
nxsaken merged 2 commits intohyperledger-iroha:mainfrom
mversic:numeric_methods
Aug 21, 2024
Merged

fix: add missing mathematical operations to Numeric#4976
nxsaken merged 2 commits intohyperledger-iroha:mainfrom
mversic:numeric_methods

Conversation

@mversic
Copy link
Copy Markdown
Contributor

@mversic mversic commented Aug 14, 2024

Context

Numeric is missing some mathematical operations and it's not possible to use it

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.

Comment thread primitives/numeric/src/lib.rs
@mversic mversic force-pushed the numeric_methods branch 2 times, most recently from 42e3180 to 1e816f8 Compare August 15, 2024 07:38
Comment thread primitives/numeric/src/lib.rs Outdated
@mversic mversic force-pushed the numeric_methods branch 3 times, most recently from 60a5e37 to 5a21b5a Compare August 15, 2024 09:58
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@nxsaken nxsaken merged commit 6c8cbf2 into hyperledger-iroha:main Aug 21, 2024
mversic added a commit that referenced this pull request Aug 30, 2024
* fix: add missing mathematical operations to `Numeric`
* fix: make operations on `Numeric` spec aware

---------

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants