Skip to content

fix(sumeragi): remove expired transaction from cache#4922

Merged
Erigara merged 2 commits intohyperledger-iroha:mainfrom
Erigara:fix_sumeragi_cache
Jul 31, 2024
Merged

fix(sumeragi): remove expired transaction from cache#4922
Erigara merged 2 commits intohyperledger-iroha:mainfrom
Erigara:fix_sumeragi_cache

Conversation

@Erigara
Copy link
Copy Markdown
Contributor

@Erigara Erigara commented Jul 31, 2024

Description

  • fix a bug in retain that actually non expired transactions were removed
  • qol improvment to print transactions by hash in the logs
    • i find it really hard to debug iroha on TRACE level in presence of heavy transactions because all logs are polluted by tx printing

Benefits

  • fewer bugs
  • more clear logs

@Erigara Erigara added the Bug Something isn't working label Jul 31, 2024
@Erigara Erigara self-assigned this Jul 31, 2024
@Erigara Erigara changed the title fix(sumeragi): remove expired transaction from hash fix(sumeragi): remove expired transaction from cache Jul 31, 2024
Erigara added 2 commits July 31, 2024 10:22
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara force-pushed the fix_sumeragi_cache branch from 8eb2aa3 to a228016 Compare July 31, 2024 07:22
Comment thread core/src/sumeragi/main_loop.rs
Comment thread core/src/tx.rs
@Erigara Erigara merged commit a62640d into hyperledger-iroha:main Jul 31, 2024
mversic pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants