fix: unnest wasm samples from client, exclude it from workspace#4863
Merged
nxsaken merged 1 commit intohyperledger-iroha:mainfrom Jul 30, 2024
nxsaken:fix/unnest_smartcontracts
Merged
fix: unnest wasm samples from client, exclude it from workspace#4863nxsaken merged 1 commit intohyperledger-iroha:mainfrom nxsaken:fix/unnest_smartcontracts
client, exclude it from workspace#4863nxsaken merged 1 commit intohyperledger-iroha:mainfrom
nxsaken:fix/unnest_smartcontracts
Conversation
mversic
previously approved these changes
Jul 23, 2024
Contributor
mversic
left a comment
There was a problem hiding this comment.
I think the change is ok
mversic
reviewed
Jul 23, 2024
DCNick3
previously approved these changes
Jul 24, 2024
Contributor
DCNick3
left a comment
There was a problem hiding this comment.
I don't think that our default executor is a terribly useful example, but having all crates that compile into on-chain wasm in one place does sound logical.
We might also want to make it more apparent which of the wasm examples are smart contracts, triggers or executors. Some naming conventions are trying to appear (executors are prefixed with _executor, triggers have _trigger somewhere in the name, smart contracts do not have those), but multisig and multisig_register kind of break this convention currently.
Contributor
Author
DCNick3
previously approved these changes
Jul 26, 2024
DCNick3
previously approved these changes
Jul 29, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
mversic
previously approved these changes
Jul 30, 2024
mversic
approved these changes
Jul 30, 2024
DCNick3
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
smartcontractsout ofclient/tests/integrationsmartcontractstowasm_samplesexecutor_custom_data_modelversion inclientwasm_samplesfrom the workspacedefault_executortowasm_samplesBenefits
fixes the error with
cargo install:package `.../client/tests/integration/smartcontracts/executor_custom_data_model/Cargo.toml` is a member of the wrong workspacewasm samples (executors, smartcontracts and triggers) are more discoverable
Dependabot updates target all wasm samples instead of just the default executor
Checklist
CONTRIBUTING.md